Kesomannen / gale

The lightweight mod manager
https://kesomannen.com/gale
GNU General Public License v3.0
124 stars 12 forks source link

Malformed ZIP files aren't extracted correctly on Linux #101

Closed notpeelz closed 2 months ago

notpeelz commented 3 months ago

Since 2af5378f9ef274e065eef379efddbd0c175423b8, BarchLib doesn't install correctly because its ZIP contains non-standard file path separators.

.
├── BepInEx\core\FSharp.Control.AsyncSeq.dll
├── BepInEx\core\FSharp.Core.dll
├── BepInEx\core\FSharpPlus.dll
├── BepInEx\core\FSharpx.Async.dll
├── BepInEx\core\libmp3lame.32.dll
├── BepInEx\core\libmp3lame.64.dll
├── BepInEx\core\NAudio.Asio.dll
├── BepInEx\core\NAudio.Core.dll
├── BepInEx\core\NAudio.dll
├── BepInEx\core\NAudio.Lame.dll
├── BepInEx\core\NAudio.Midi.dll
├── BepInEx\core\NAudio.Wasapi.dll
├── BepInEx\core\NAudio.WinForms.dll
├── BepInEx\core\NAudio.WinMM.dll
├── BepInEx\core\UniTask.Addressables.dll
├── BepInEx\core\UniTask.dll
├── BepInEx\core\UniTask.DOTween.dll
├── BepInEx\core\UniTask.Linq.dll
├── BepInEx\core\UniTask.TextMeshPro.dll
├── BepInEx\core\WebRtcVad.dll
├── BepInEx\core\WebRtcVad.pdb
├── BepInEx\core\WebRtcVadSharp.dll
├── BepInEx\core\WebRtcVadSharp.pdb
├── icon.png
├── manifest.json
└── README.md

This results in filenames with literal backslashes in the BepInEx/plugins folder.

SolakkaSilakka commented 3 months ago

Here's a screenshot of how it looks like on my end. kuva

gusruben commented 3 months ago

Can confirm, this happens to me too. The game runs fine if I manually extract/move the files to the right place.

Kesomannen commented 3 months ago

Well, that's dumb

Kesomannen commented 2 months ago

Should be fixed in 0.8.3

notpeelz commented 2 months ago

Appears to be fixed. I just had to clear the cache in order to fix the misplaced files.