Ketho / vscode-wow-api

VS Code extension for World of Warcraft AddOns
https://marketplace.visualstudio.com/items?itemName=ketho.wow-api
MIT License
154 stars 33 forks source link

Minor: SetCursor parameter should be optional #117

Closed Arxareon closed 1 year ago

Arxareon commented 1 year ago

Hey!

I found a minor annotation error, the "cursor" parameter for the API function SetCursor should be optional.

I changed line 1278 in API4.lua to (and updated the wiki page:

---@param cursor? string

🫰

Ketho commented 1 year ago

Oh, thanks. Is that an explicit nil or can it just be omitted? The extension should pick it up in the next update.

Arxareon commented 1 year ago

Never mind, it does have to be an explicit nil. I just tested it again. When it was pushed to in-game testing I was actually passing nil through a variable to it so I didn't notice.

I've reverted the wiki changes (I saw you added the brackets I left out).

Sorry, and thanks for the question!