search

KevM / tikaondotnet

Use the Java Tika text extraction library on the .NET platform
http://kevm.github.io/tikaondotnet/
Apache License 2.0
195 stars 73 forks source link

Update paket to address TLS deprecation #115

Closed forki closed 6 years ago

forki commented 6 years ago

:wave: GitHub disabled TLS 1.0 and TLS 1.1 on February 22nd, which affected Paket and needs to be updated to 5.142 or later.

You can read more about this on the GitHub Engineering blog.

The update to Paket is explained here: https://github.com/fsprojects/Paket/pull/3066

The work to update Paket in the wild is occurring here: https://github.com/fsprojects/Paket/issues/3068

KevM commented 6 years ago

Thank you for the PR. I really appreciate it. Hmm, looks like maybe the paket restore is not working on the Appveyor CI. Not sure why. It works for me locally.

forki commented 6 years ago

mmm let me take a look

forki commented 6 years ago

ok found the issue.

in the appveyor.yml you do

cache:
  - paket-files -> paket.lock # cache HTTP downloads until packet.lock is changed.

but inside that folder we have a paket.restore.cached file which should not be cached. It determines if we need to restore or not. you need to exclude that from appveyor caching

/cc @matthid

matthid commented 6 years ago

@forki feel free to move that file somewhere else. Problem is we have no path where we recommend to gitignore it ;).

.paket is not gitignored so it will lead to problems with paket-files and packages folder paket-files will lead to problems like above packages will lead to problems with paket-files ;)

we can move it to .paket.gitignore.me if you think that will work ;)

forki commented 6 years ago

renaming will only bring new trouble ;-) we need some way to sanity check it

matthid commented 6 years ago

We can print a warning if we detect git and detect that it is part of source control ;)

forki commented 6 years ago

would not help in this case...