search

KevinBatdorf / liquidslider

A Responsive jQuery Content Slider
161 stars 63 forks source link

Continuous feature creates clone slides which prevent some functionalities #125

Closed tumezuki closed 10 years ago

tumezuki commented 10 years ago

Kevin mentioned in this issue (https://github.com/KevinBatdorf/liquidslider/issues/96) that continuous-feature creates clones for the first and the last slide.

This "cloning" prevents using id values at those slides because duplicate id values. And of course when the exact same element is in two places everything goes crazy when setting/getting the correct value.

The easy way out is setting the continuous to false but I think this isn't always the desired solution. For me it's ok for now but maybe not later on.

tumezuki commented 10 years ago

I noticed there is actually several issues referring to this thing. But I still think that it needs a proper fix. I know it's not the easiest thing to get done but anyway.. I keep my fingers crossed!

KevinBatdorf commented 10 years ago

I think it's up to the developer to use proper selector and content strategy choices when displaying their information. Each clone has a class of clone applied to it so developers can select the clones accordingly.

For example, to select a field that doesn't include the clone:

$('.panel:not(.clone) #email-field')

And perhaps another function to mirror the form, if needed (or just disable the panel switching while form fields are populated with data)