search

Khachig / notation.nvim

Note management plugin for Neovim
5 stars 0 forks source link

Notes goes to v:null/Inbox #3

Open pilarskikt opened 9 months ago

pilarskikt commented 9 months ago

Hi, at first i love the idea of this plugin and it's simplicity. It is exactly what i was looking for. Have strange issue just as in title my notes instead of configured directory they goes to v:null/Inbox. Maybe i'm doing something wrong ( btwi'm using Lazy to load the plugin if that helps)

Khachig commented 8 months ago

Hey!

Sorry to get back to you a few weeks late, but I'm glad you like the plugin. I didn't even think anyone was using it!

Seeing the v:null/Inbox, my first instinct is that it could have something to do with what vim.fn.expand is returning for "\~" because I've hardcoded "~/Inbox" for the home directory only thinking about Unix-based setups.

Could you give me a little bit more detail about your setup and the issue? What OS are you using? Does the issue happen when you manually set the notes_dir or only when left to default or both?

Khachig commented 8 months ago

@pilarskikt I figured out the issue! It had to do with some subtle faulty logic on my part when picking between options.notes_dir vs the default ~/Notes. I was calling vim.fn.expand on options.notes_dir not realizing that if the value is nil it would get expanded to v:null, which is not the same as a nil value in lua so it ended up getting selected by default. The change was trivial and it should work properly now if you update the plugin to the latest commit.

pilarskikt commented 8 months ago

Hi @Khachig, thanks for looking into this. I will give it a try soon.