Don't miss store changes between getInitialState and mount (fixes #38)

Khan / react-components

khan.github.io/react-components/

MIT License

1.01k stars 99 forks source link

Closed zgotsch closed 6 years ago

zgotsch commented 9 years ago

I haven't tested this (I wish there were tests). @benkomalo or @jlfwong, would you take a look at this?

sophiebits commented 9 years ago

Doesn't this still not catch the case where there are changes between componentWillMount and componentDidMount?

zgotsch commented 9 years ago

Oh man can that happen? :p I'll fix this later today if I remember

sophiebits commented 9 years ago

Well, it probably shouldn't happen between getInitialState and componentDidMount either. See my comment on #38.