Sign macOS binaries in CI

KhiopsML / khiops

Khiops is an AutoML suite for supervised and unsupervised learning

https://khiops.org

BSD 3-Clause Clear License

36 stars 4 forks source link

Sign macOS binaries in CI #224

Closed folmos-at-orange closed 4 months ago

folmos-at-orange commented 7 months ago

Description

The PR #214 added the osx-arm64 build for the conda khiops executables. Since in osx-arm64 non signed binaries add unwanted popups we should sign them.

Questions/Ideas

Add the macOS certificate to the secrets
Change the signature code in packaging/conda/build.shso it is signed only on request
- Currently it is triggered by setting a specific environment variables.

folmos-at-orange commented 7 months ago

After discussion in weekly:

Put secrets in vault immediatly
Put the signature flag afterwards solving this issue.

folmos-at-orange commented 7 months ago

After thinking about it even just putting the secrets in the vault needs a change in the code. So I think I'll leave all this work for later.

lucaurelien commented 4 months ago

Done in PR #330 and #332