search

KhiopsML / khiops

Khiops is an AutoML suite for supervised and unsupervised learning
https://khiops.org
BSD 3-Clause Clear License
36 stars 4 forks source link

Add a "no suffix" generation in CMake even if MPI is available #250

Open bruno-at-orange opened 6 months ago

bruno-at-orange commented 6 months ago

In conda we do not need the MPI suffixes, and it would simplify the lookup for the executable. At the moment I just rename it after the build.

bruno-at-orange commented 6 months ago

We can easily add a new option in the CMakeFiles.txt e.g. NO_MPI_SUFFIX. But it will introduce an inconsistency in cmake: if NO_MPI_SUFFIX=OFF, cpack will fail with DEB and RPM as it requires now mpi suffixes. There is perhaps another way: why not use a symlink from MODL to MODL_suffix as it is done with DEB and RPM. Even better we could use cmake install command in conda.

bruno-at-orange commented 6 months ago

Actually, the mpi suffix discovering process fails on conda (all mpi libs are located on the same directory, there is no information about the mpi implementation AFAIK). Then there is no suffix under conda environment. It is more a good side-effect than a feature.

alexisbondu commented 6 months ago

Regarder le lien avec Khiops Env pour une intégration propre dans pyKhiops => simplification possible ?