KhiopsML / khiops

Khiops is an AutoML suite for supervised and unsupervised learning
https://khiops.org
BSD 3-Clause Clear License
34 stars 4 forks source link

Conda build fails on windows #271

Closed bruno-at-orange closed 5 months ago

bruno-at-orange commented 6 months ago

There is an issue with the compiler setting: https://github.com/KhiopsML/khiops/actions/runs/9210331235/job/25337089165#logs

folmos-at-orange commented 5 months ago

After some investigation the source of the problem comes from a change in the GitHub runners: https://github.com/actions/runner-images/issues/9701. In summary, before this change, the runner's VS installation contained many versions of the runtime and build tools. After the change only those of VS 2022 remained. Since conda uses a previous version of the VS runtime the build fails.

I implemented a POC fix in this branch that largely consists in adding the vs2022_win-64 package to the conda windows build (see this workflow run). However this impose us the constraint of adding conda-forge to the installation process in windows. Nonetheless, implementing this fix helped me to understand better the problem.

I will try another fix by installing the necessary components in the runner before building the conda package. If this works we should be able to obtain the same package as before (without new dependencies and channels).

folmos-at-orange commented 5 months ago

Simply changing the GitHub runner to windows-2019 fixes the problem.

I tried to install myself VS 2017 in the runner but it did not work. I propose for the moment merging PR #288 because:

folmos-at-orange commented 5 months ago

Another useful link: List of removed components https://github.com/actions/runner-images/pull/9819/files

alexisbondu commented 5 months ago

fixed : #288