KhiopsML / khiops

Khiops is an AutoML suite for supervised and unsupervised learning
https://khiops.org
BSD 3-Clause Clear License
34 stars 4 forks source link

Issue in pre-commit action #353

Closed bruno-at-orange closed 2 months ago

bruno-at-orange commented 3 months ago

Description

The pre-commit action fails on yamlfix. It seems it comes from a cache issue that produces the final error "ModuleNotFoundError: No module named 'maison.schema'" in yamlfix.

In the commit 5fed3d16fb2827d073acc37c6caca510f086b9b3, I updated the versions of the actions without improvment. So I comment the yamlfix in the file .pre-commit-config.yaml. The checks are OK and we can work, but the bug remains.

Questions/Ideas

folmos-at-orange commented 2 months ago

1) yamlfix fixed the "maison" module error in its latest version 1.17.0(it's from 2 weeks ago so it probably didn't exist when you tested). I tested and it works fine. 2) The maintainers of the pre-commit action say that is "maintainance-only" so the action is not deprecated and I think we can safely use it.

folmos-at-orange commented 2 months ago

yamlfix was updated in #366 for dev and in #367 for dev-v10. I think we can safely close this.