search

Khiro95 / Awqat-Salaat

A simple Windows widget to show the time of the next prayer alongside a countdown on the taskbar.
MIT License
52 stars 2 forks source link

Some suggestions #10

Closed AbdesamedBendjeddou closed 3 months ago

AbdesamedBendjeddou commented 5 months ago

Salam, Great work, Glad that I found this when I was thinking about making one myself. I have some suggestions that I was going to implement on my app inspired by how I wanted my app to behave:

Khiro95 commented 5 months ago

Wa Alaykum Assalam, and thank you for your kind words.

I want to start by discussing the last point about the position. Your screenshots seem to indicate that the widget has failed to position itself correctly. You seem to have the taskbar aligned to the center but the widget think it's left-aligned. So I have few questions to help me understand the problem:

Khiro95 commented 5 months ago
  • any reason why the app is not in the Microsoft Store? for easier update

I don't have a way to pay for developer account. I'm willing to pay but I don't have the means.

AbdesamedBendjeddou commented 5 months ago

image

I don't have a way to pay for a developer account. I'm willing to pay but I don't have the means.

I thought it was still free, haven't checked in a while

Khiro95 commented 5 months ago

there is no TaskbarAl value, but I'm not sure if this is the correct path, you didn't mention the root folder.

My bad, I apologize. The root is current user.

AbdesamedBendjeddou commented 5 months ago

image Nothing here either

Khiro95 commented 5 months ago

image Nothing here either

Ok, that's weird a little since the widget default to center alignment when TaskbarAl is missing.

Will test that case and see.

Khiro95 commented 5 months ago

Ok, I can repro the problem. Thanks for reporting it :)

Khiro95 commented 5 months ago

As a quick fix, you can add TaskbarAl to the registry and give it value 1.

Khiro95 commented 5 months ago
  • to minimize the size of the widget as you discussed in a previous issue, we can have the widget show the next prayer time until the time the user chooses to be notified, the widget then should switch to a countdown

That's a good suggestion.

  • Like Salatuk, the widget displays elapsed time since the Athan at first and then switches to showing the next prayer time later (I don't know exactly how much elapsed passed before switching to the next prayer time but I believe Salatuk split the time in half.

Not sure I understand the point of showing the time elapsed since Athan.

AbdesamedBendjeddou commented 5 months ago

image

it worked, I just need to disable the widgets panel. As I mentioned I don't know much yet about Windows app SDK but what options does the API expose, in Linux desktop Gnome for example you get to set an offset value so widgets don't overlap, every offset increment or decrement will move your widget one position left or right. I don't know if this possible in the app SDK

AbdesamedBendjeddou commented 5 months ago

Not sure I understand the point of showing the time elapsed since Athan.

personally, I used to see how much time I still had to get to the mosque before the prayer started. or how much I'm late to the prayer before it's time end

Khiro95 commented 5 months ago

The widget is already aware of "Widgets" button of Windows 11. It fail sometime when you enable/disable that button, but if it's already there when the widget position itself, it should not overlap it. image

As for positioning the widget manually, like in Linux, this is doable but I just need to find some time to do it 😁 It's a little hard but it's worth it for sure.

Khiro95 commented 5 months ago

Not sure I understand the point of showing the time elapsed since Athan.

personally, I used to see how much time I still had to get to the mosque before the prayer started. or how much I'm late to the prayer before it's time end

Ok, I get your point. We can add this feature for sure.

AbdesamedBendjeddou commented 5 months ago

great thanks.