KhronosGroup / OpenXR-Tutorials

OpenXR Tutorials
https://www.openxr-tutorial.com/
Apache License 2.0
86 stars 15 forks source link

links are not clickable #78

Closed rbessems closed 1 year ago

rbessems commented 1 year ago

take the build tag as an input to the build system then use that to link to the chapter zip files on github.

for example: https://github.com/KhronosGroup/OpenXR-Tutorials/releases/download/v0.0.2/Chapter1.zip

AndrewRichards-Code commented 1 year ago

Commits 4e888a6 to 29a4b7c have resolved this issue. The git tag is passed from the GitHub action to build-site.sh and ultimately onto sphinx where we place it in the URL for the download links. These zip download links, which link to this repo's Git Release page, don't automatically download the archives. I think only the rst :download: tag can do that. Regardless, the links work and you can download the zip archive. https://github.com/KhronosGroup/OpenXR-Tutorials/releases/tag/v0.0.5/

rbessems commented 1 year ago

Looks like if the link is formatted as follows:

https://github.com/KhronosGroup/OpenXR-Tutorials/releases/download/v0.0.5/Chapter3.zip

it does work directly.

Currently the link is https://github.com/KhronosGroup/OpenXR-Tutorials/releases/tag/v0.0.5/Chapter3.zip

AndrewRichards-Code commented 1 year ago

Commit 28be71e updates the rst :git_release: tag to the use link that automatically downloads the zip archive. @rbessems, Thank you so much for the help.

rbessems commented 1 year ago

Strangely v6 still doesn't work right (wrong url)

AndrewRichards-Code commented 1 year ago

Unfortunately, the GitHub Actions are still queued: https://github.com/KhronosGroup/OpenXR-Tutorials/actions

AndrewRichards-Code commented 1 year ago

All those pending GitHub Actions are now finished, and the site is updated. I have just tried the links and was able to download the archives.

rbessems commented 1 year ago

looks good.