search

KhronosGroup / VK-GL-CTS

Khronos Vulkan, OpenGL, and OpenGL ES Conformance Tests
https://www.khronos.org/
Apache License 2.0
525 stars 293 forks source link

Add missing cmath includes #470

Closed nico closed 2 months ago

nico commented 3 months ago

These files use std::fabs() but didn't include . This used to work due to transitive includes. But a recent libc++ removes enough transitive includes that cmath now needs an explicit include.

No behavior change.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

nico commented 3 months ago

(Our upstream bug for this is https://crbug.com/354741410)

ShabbyX commented 3 months ago

This is fixed by https://gerrit.khronos.org/c/vk-gl-cts/+/15107 FYI, which hasn't landed yet. Taking this change at the same time is redundant, but harmless.

nico commented 3 months ago

I'd like us to pick this up as quickly as possible in chromium, so that we can re-enable smaller includes. If taking this change helps with this, please do so.

(ps: Your link is behind a login wall, so I can't see it.)