KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.36k stars 648 forks source link

Fix offset of BufferAllocation with C-bindings path (again) #1143

Closed asuessenbach closed 2 months ago

asuessenbach commented 2 months ago

Description

This had been fixed before by #1127, but has inadvertently been reverted by #1104, which was older but merged later.

Build tested on Win10 with VS2022. Run tested on Win10 with NVidia GPU.

Fixes #1142

General Checklist:

Please ensure the following points are checked:

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

gary-sweet commented 2 months ago

@marty-johnson59 We might want to consider fast tracking this fix. It was already fixed once, and has been overwritten by a more recent merged PR. Would be good to get it back in as it does break some samples.

marty-johnson59 commented 2 months ago

OK, per Gary's suggestion, I'll merge this with 2 approvals - LMK if issues and we can revert