KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.36k stars 648 forks source link

Fix build of samples dynamic rendering local read and host image copy #1155

Closed brimston3 closed 2 months ago

brimston3 commented 2 months ago

Description

PR #887 predated vkb::core::CppBuffer merge, change type used to BufferC in samples dynamic rendering local read and host image copy.

Fixes #1154.

General Checklist:

Please ensure the following points are checked:

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

SaschaWillems commented 2 months ago

Thanks for catching this. Very unfortunate, maybe we need to rethink how we merge large framework changes to avoid this.

Will merge once CI has run.

SaschaWillems commented 2 months ago

@brimston3 : Bummer. It fails with clang format. Can you fix that? If not I could take a look, but might take a while.

brimston3 commented 2 months ago

@SaschaWillems My mistake, I've run the formatter now and committed the changes.

SaschaWillems commented 2 months ago

Thank you very much 👍🏻