Closed brimston3 closed 2 months ago
Thanks for catching this. Very unfortunate, maybe we need to rethink how we merge large framework changes to avoid this.
Will merge once CI has run.
@brimston3 : Bummer. It fails with clang format. Can you fix that? If not I could take a look, but might take a while.
@SaschaWillems My mistake, I've run the formatter now and committed the changes.
Thank you very much 👍🏻
Description
PR #887 predated vkb::core::CppBuffer merge, change type used to BufferC in samples dynamic rendering local read and host image copy.
Fixes #1154.
General Checklist:
Please ensure the following points are checked:
[ ] This PR describes the scope and expected impact of the changes I am making
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: