KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.36k stars 648 forks source link

Change present mode fallback priority to: eMailbox -> eImmediate -> eFifo #1160

Closed SRSaunders closed 2 months ago

SRSaunders commented 2 months ago

Description

This changes the fallback priority for present mode from eMailbox -> eFifo -> eImmediate to eMailbox -> eImmediate -> eFifo. By setting eFifo (vsync mode) as the lowest priority/last fallback option, the --vsync <ON|OFF> command line switch can function in all environments where eMailbox or eImmediate mode is available. It also has the effect of making the default (no command line option) mode either eMailbox or eImmediate (i.e. non vsync) which should be beneficial for comparing performance overlay stats in the samples.

Fixes #1159

General Checklist:

Please ensure the following points are checked:

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

SRSaunders commented 2 months ago

Not sure how a single line change results in a changed-files CI failure. Perhaps the CI run could be retriggered?