KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.36k stars 648 forks source link

Move the hlsl shader tasks into their own folder #1164

Closed gpx1000 closed 2 months ago

gpx1000 commented 2 months ago

Fixes #1156

General Checklist:

Please ensure the following points are checked:

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

SRSaunders commented 2 months ago

@gpx1000 While I can't formally approve, I have tested this using both Xcode (macOS/iOS) and Visual Studio (Win 10) and it works well. Just thought you might want to know about the Xcode improvement as well, since it suffered the same top level project issue as VS (#1156).

gpx1000 commented 2 months ago

Awesome thanks @SRSaunders. I think this should be good to go when we do our call on Monday. I typically test XCode every other week or so and Windows around the same cadence so it's easy for me to miss bugs like this. My day to day I'm in Linux.