Add compile option -fno-strict-aliasing for all compilers but MSVC.

asuessenbach commented 3 weeks ago

Description

Due to using reinterpret_casts in our code base, we need to set -fno-strict-aliasing for all compilers but MSVC (which does not have such a switch but acts as if it were set) to prevent potentially wrong optimizations.

Fixes #1207

General Checklist:

Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:
- [x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
- [ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
If this PR contains framework changes:
- [ ] I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[ ] I have tested the sample on at least one compliant Vulkan implementation
[ ] If the sample is vendor-specific, I have tagged it appropriately
[ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[ ] Any dependent assets have been merged and published in downstream modules
[ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
[ ] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
[ ] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

jeroenbakker-atmind commented 2 weeks ago

I will test on Mac&Linux desktop this week.

jeroenbakker-atmind commented 2 weeks ago

Validated on

Operating system: Linux-6.8.0-48-generic-x86_64-with-glibc2.39 64 Bits, WAYLAND UI
Graphics card: AMD Radeon PRO W6800 Advanced Micro Devices AMD proprietary driver (AMD proprietary shader compiler)

Operating system: macOS-14.6.1-arm64-arm-64bit 64 Bits
Graphics card: Apple M2 Apple MoltenVK 1.2.11

marty-johnson59 commented 2 weeks ago

Merging with Steve and Jeroen's approvals per discussion on Monday

KhronosGroup / Vulkan-Samples