search

KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.06k stars 604 forks source link

Duplicate declaration of update_overlay in api sample base clase #989

Open SaschaWillems opened 3 months ago

SaschaWillems commented 3 months ago

The api sample base class (based on my samples) always had a function called update_overlay in the protected part of the class:

https://github.com/KhronosGroup/Vulkan-Samples/blob/0d0cf9b90541d349ceb49682d063d27a8c2432de/framework/api_vulkan_sample.h#L357

At some point some PR seems to have introduced a virtual function with the same name in the public part:

https://github.com/KhronosGroup/Vulkan-Samples/blob/0d0cf9b90541d349ceb49682d063d27a8c2432de/framework/api_vulkan_sample.h#L115

MSVC is picking this up:

image

It looks like the virtual function was supposed to replace the old one, but the old declaration hasn't been removed.

SaschaWillems commented 3 months ago

Looking at that base class it also seems like a lot of recent changes were made without documentation and that there now are two public section. I'll probably do a clean up pass over the whole base class.