search

KhubaibKhan4 / MediaPlayer-KMP

MediaPlayer-KMP is a Kotlin Multiplatform (KMP) library that allows you to display and play YouTube videos across Android, iOS, Web, and Desktop platforms using JetBrains Compose Multiplatform. It provides a unified API for video playback that seamlessly integrates into Kotlin's multiplatform ecosystem.
MIT License
61 stars 3 forks source link

Full Screen Support #9

Open LaatonWalaBhoot opened 1 month ago

LaatonWalaBhoot commented 1 month ago

Hi, great work on the library. Would it be possible to allow full-screen support to the Youtube Videos?

KhubaibKhan4 commented 1 month ago

Yes, we can display videos in a full screen but it's working in Web right now. In the upcoming update, I'll definitely add the full screen support for all the platforms. Thank you for your suggestion.

LaatonWalaBhoot commented 1 month ago

I have a few other questions. Sorry to bother you but is it possible to display youtube videos in a LazyColumn? And does it preserve the video state while scrolling? I could not find a sample. Should I open a separate issue for this? @KhubaibKhan4

KhubaibKhan4 commented 1 month ago

Thank you for another suggestion. Yeah, we can display youtube videos inside the lazy column as well but there's no official support for playing youtube videos. We're using JavaFx e.g, So we're it didn't persist the video state.

LaatonWalaBhoot commented 1 month ago

Is it possible to persist Video state like Twitter does? With an Android webview the issue that I face is it causes reload on scrolling Plus the webview is itself unscrollable and hogs all touches of the lazy column

KhubaibKhan4 commented 1 month ago

There's only way to hold the state using mutableMapState. by that we can hold the current Video Ids and return when we revisit them. This method is mostly used in applications to persist the data. I'll try to include the persistence of video players in YouTube. It's do it.

LaatonWalaBhoot commented 1 month ago

That would be great. Any idea about the timeline for this @KhubaibKhan4 ?

KhubaibKhan4 commented 1 month ago

I'm planning to work on a sprint of 15 days. Hopefully, will achieve in this sprint.

LaatonWalaBhoot commented 3 weeks ago

Any update on this @KhubaibKhan4 ?

KhubaibKhan4 commented 3 weeks ago

Unfortunately, I'm busy with tickets. Will be doing soon.

LaatonWalaBhoot commented 2 weeks ago

No worries. Looking forward to it.

LaatonWalaBhoot commented 6 days ago

@KhubaibKhan4 saw that you marked it as completed but I couldn't find the functionality

KhubaibKhan4 commented 6 days ago

I accidentally closed this issue. Let me add the functionality of full screen as well.