search

KillerCodeMonkey / ngx-quill

Angular (>=2) components for the Quill Rich Text Editor
MIT License
1.77k stars 258 forks source link

ng build --prod error #573

Closed craig-dae closed 4 years ago

craig-dae commented 5 years ago

Error below happens on 7.3.4. Does not happen on 7.3.2. Have not tried 7.3.3.

Happens during an ng build --prod. 

ERROR in ./node_modules/ngx-quill/fesm5/ngx-quill.js
Module build failed (from ./node_modules/@angular-devkit/build-optimizer/src/build-optimizer/webpack-loader.js):
TypeError: Cannot read property 'kind' of undefined
    at isAngularDecoratorMetadataExpression (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:265:35)
    at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:77:21)
    at visitNodes (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16514:30)
    at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16740:24)
    at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31)
    at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24)
    at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16635:21)
    at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31)
    at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24)
    at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16692:24)
    at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31)
    at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24)
    at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16703:24)
    at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31)
    at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24)
    at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16599:21)
KillerCodeMonkey commented 5 years ago

Could you try 7.3.3 please ?

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 17:57:

Error below happens on 7.3.4. Does not happen on 7.3.2. Have not tried 7.3.3.

Happens during an ng build --prod.

ERROR in ./node_modules/ngx-quill/fesm5/ngx-quill.js Module build failed (from ./node_modules/@angular-devkit/build-optimizer/src/build-optimizer/webpack-loader.js): TypeError: Cannot read property 'kind' of undefined at isAngularDecoratorMetadataExpression (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:265:35) at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:77:21) at visitNodes (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16514:30) at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16740:24) at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31) at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24) at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16635:21) at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31) at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24) at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16692:24) at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31) at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24) at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16703:24) at checkNodeForDecorators (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/src/transforms/scrub-file.js:68:31) at visitNode (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16505:24) at Object.forEachChild (/home/cfloyd/dev/valkyrie/frontend/angular/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:16599:21)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YHUCDQADTMKNXKYX4LQOCO4ZA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HRH5SYA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YBTCBOOLK6JJHUZ2LTQOCO4ZANCNFSM4I73R4UA .

KillerCodeMonkey commented 5 years ago

@craig-dae https://killercodemonkey.github.io/ngx-quill-example/ is build with ng build --prod and it is working fine ;-).

KillerCodeMonkey commented 5 years ago

do you upgraded typescript or something like that?

sometimes such errors occur when you are using an incompatible typescript version with angular

craig-dae commented 5 years ago

7.3.3 produces the same error. Below are the dependencies in my package.json: 

"dependencies": {
    "@agm/core": "1.0.0-beta.5",
    "@angular/animations": "8.1.1",
    "@angular/cdk": "8.0.0",
    "@angular/common": "8.1.1",
    "@angular/compiler": "8.1.1",
    "@angular/core": "8.1.1",
    "@angular/flex-layout": "^8.0.0-beta.26",
    "@angular/forms": "8.1.1",
    "@angular/material": "8.0.0",
    "@angular/platform-browser": "8.1.1",
    "@angular/platform-browser-dynamic": "8.1.1",
    "@angular/router": "8.1.1",
    "@fortawesome/fontawesome-free": "5.5.0",
    "@ngrx/effects": "^8.2.0",
    "@ngrx/entity": "^8.2.0",
    "@ngrx/router-store": "^8.2.0",
    "@ngrx/schematics": "^8.2.0",
    "@ngrx/store": "^8.2.0",
    "@ngrx/store-devtools": "^8.2.0",
    "@ngx-progressbar/core": "^5.3.2",
    "@ngx-progressbar/http": "^5.3.2",
    "@ngx-translate/core": "11.0.1",
    "@ngx-translate/http-loader": "4.0.0",
    "@swimlane/ngx-datatable": "15.0.0",
    "@thisissoon/angular-inviewport": "^4.2.0",
    "angular2-text-mask": "9.0.0",
    "bootstrap": "4.3.1",
    "chart.js": "2.7.3",
    "classlist.js": "1.1.20150312",
    "core-js": "2.5.4",
    "easy-pie-chart": "2.1.7",
    "enhanced-resolve": "3.3.0",
    "eslint": "^5.16.0",
    "hammerjs": "2.0.8",
    "intl": "1.2.5",
    "jqcloud2": "2.0.3",
    "jquery": "^3.4.1",
    "jquery-slimscroll": "1.3.8",
    "jquery-sparkline": "2.4.0",
    "jquery.browser": "0.1.0",
    "lodash": "4.17.11",
    "modernizr": "^3.7.1",
    "moment": "2.22.2",
    "ng2-charts": "1.6.0",
    "ng2-file-upload": "1.3.0",
    "ng2-material-dropdown": "0.10.1",
    "ng2-validation": "4.2.0",
    "ngrx-store-freeze": "^0.2.4",
    "ngx-bootstrap": "4.2.0",
    "ngx-chips": "2.0.2",
    "ngx-clipboard": "^12.1.2",
    "ngx-infinite-scroll": "6.0.1",
    "ngx-page-scroll-core": "^6.0.2",
    "ngx-quill": "7.3.3",
    "ngx-select-ex": "^3.6.11-dev",
    "ngx-toastr": "^10.0.4",
    "popper.js": "1.14.3",
    "quill": "^1.3.6",
    "roboto-fontface": "0.10.0",
    "rxjs": "6.5.2",
    "rxjs-compat": "6.1.0",
    "simple-line-icons": "2.4.1",
    "spinkit": "1.2.5",
    "summernote": "0.8.10",
    "sweetalert": "2.1.2",
    "ts-helpers": "1.1.1",
    "tslib": "^1.10.0",
    "uuid": "^3.3.2",
    "web-animations-js": "2.2.1",
    "zone.js": "0.9.1"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.800.0",
    "@angular/cli": "8.0.1",
    "@angular/compiler-cli": "8.1.1",
    "@angular/language-service": "8.1.1",
    "@types/jasmine": "2.8.8",
    "@types/jasminewd2": "2.0.3",
    "@types/lodash": "4.14.118",
    "@types/node": "10.12.3",
    "codelyzer": "4.5.0",
    "cypress": "3.3.1",
    "loaders.css": "0.1.2",
    "protractor": "5.4.0",
    "ts-node": "7.0.0",
    "tslint": "5.11.0",
    "typescript": "3.4.5",
    "webdriver-manager": "10.2.5"
  }
KillerCodeMonkey commented 5 years ago

But with 7.3.3. nothing Special changed and only some Dev deps changed.

Did You changed Something Else?

Or could you create a fresh ng cli Project with ngx-quill?

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 18:30:

7.3.3 produces the same error. Below are the dependencies in my package.json:

"dependencies": { "@agm/core": "1.0.0-beta.5", "@angular/animations": "8.1.1", "@angular/cdk": "8.0.0", "@angular/common": "8.1.1", "@angular/compiler": "8.1.1", "@angular/core": "8.1.1", "@angular/flex-layout": "^8.0.0-beta.26", "@angular/forms": "8.1.1", "@angular/material": "8.0.0", "@angular/platform-browser": "8.1.1", "@angular/platform-browser-dynamic": "8.1.1", "@angular/router": "8.1.1", "@fortawesome/fontawesome-free": "5.5.0", "@ngrx/effects": "^8.2.0", "@ngrx/entity": "^8.2.0", "@ngrx/router-store": "^8.2.0", "@ngrx/schematics": "^8.2.0", "@ngrx/store": "^8.2.0", "@ngrx/store-devtools": "^8.2.0", "@ngx-progressbar/core": "^5.3.2", "@ngx-progressbar/http": "^5.3.2", "@ngx-translate/core": "11.0.1", "@ngx-translate/http-loader": "4.0.0", "@swimlane/ngx-datatable": "15.0.0", "@thisissoon/angular-inviewport": "^4.2.0", "angular2-text-mask": "9.0.0", "bootstrap": "4.3.1", "chart.js": "2.7.3", "classlist.js": "1.1.20150312", "core-js": "2.5.4", "easy-pie-chart": "2.1.7", "enhanced-resolve": "3.3.0", "eslint": "^5.16.0", "hammerjs": "2.0.8", "intl": "1.2.5", "jqcloud2": "2.0.3", "jquery": "^3.4.1", "jquery-slimscroll": "1.3.8", "jquery-sparkline": "2.4.0", "jquery.browser": "0.1.0", "lodash": "4.17.11", "modernizr": "^3.7.1", "moment": "2.22.2", "ng2-charts": "1.6.0", "ng2-file-upload": "1.3.0", "ng2-material-dropdown": "0.10.1", "ng2-validation": "4.2.0", "ngrx-store-freeze": "^0.2.4", "ngx-bootstrap": "4.2.0", "ngx-chips": "2.0.2", "ngx-clipboard": "^12.1.2", "ngx-infinite-scroll": "6.0.1", "ngx-page-scroll-core": "^6.0.2", "ngx-quill": "7.3.3", "ngx-select-ex": "^3.6.11-dev", "ngx-toastr": "^10.0.4", "popper.js": "1.14.3", "quill": "^1.3.6", "roboto-fontface": "0.10.0", "rxjs": "6.5.2", "rxjs-compat": "6.1.0", "simple-line-icons": "2.4.1", "spinkit": "1.2.5", "summernote": "0.8.10", "sweetalert": "2.1.2", "ts-helpers": "1.1.1", "tslib": "^1.10.0", "uuid": "^3.3.2", "web-animations-js": "2.2.1", "zone.js": "0.9.1" }, "devDependencies": { "@angular-devkit/build-angular": "~0.800.0", "@angular/cli": "8.0.1", "@angular/compiler-cli": "8.1.1", "@angular/language-service": "8.1.1", "@types/jasmine": "2.8.8", "@types/jasminewd2": "2.0.3", "@types/lodash": "4.14.118", "@types/node": "10.12.3", "codelyzer": "4.5.0", "cypress": "3.3.1", "loaders.css": "0.1.2", "protractor": "5.4.0", "ts-node": "7.0.0", "tslint": "5.11.0", "typescript": "3.4.5", "webdriver-manager": "10.2.5" }

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YETL3J5NCOBRBDX7ALQOCS4BA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAQ2OQ#issuecomment-541134138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YHQT65F7ZVZB6F3ZI3QOCS4BANCNFSM4I73R4UA .

craig-dae commented 5 years ago

We added quill to our project a few weeks ago. The bug only recently started happening this morning. We noticed your version bump from yesterday, so that's the path we went down.

This is a project in active development, so yeah, we've modified a lot. None of our recent changes have anything to do with quill though. They are related to the form where quill is used.

KillerCodeMonkey commented 5 years ago

Could you try to remove your node modules Folder an Reinstall the dependencies?

Or remove your lockfile node_modules und Reinstall the deps

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 18:38:

We added quill to our project a few weeks ago. The bug only recently started happening this morning. We noticed your version bump from yesterday, so that's the path we went down.

This is a project in active development, so yeah, we've modified a lot. None of our recent changes have anything to do with quill though. They are related to the form where quill is used.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YBY7Z6VV5FEZQZMBC3QOCTXNA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBARO2A#issuecomment-541136744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YEIYW4Y2A7DNIFIXDTQOCTXNANCNFSM4I73R4UA .

craig-dae commented 5 years ago

I did that the first time, but I'm not confident that I did that with 7.3.3, after successfully building 7.3.2. I'll do it again with 7.3.3.

KillerCodeMonkey commented 5 years ago

I am curious because the dependency Changes are only minors and hotfixes

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 19:15:

I did that the first time, but I'm not confident that I did that with 7.3.3, after successfully building 7.3.2. I'll do it again with 7.3.3.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YCNZKIQTG6CWXFBK5LQOCYENA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAUSCQ#issuecomment-541149450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YBTJ27GLV7WXU5MYG3QOCYENANCNFSM4I73R4UA .

craig-dae commented 5 years ago

Same result (the error). I'm going to do it again with 7.3.2 as a sanity check. Deleting the folder and building again.

craig-dae commented 5 years ago

7.3.2 built again just fine

KillerCodeMonkey commented 5 years ago

Thats Strange. Maybe ng-packager changed Something that Breaks older angular Versions.

Because IT IS working with the latest angular 8 ones.

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 19:28:

7.3.2 built again just fine

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YBJCTMKE6JASOEXGXDQOCZVTA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAVUXQ#issuecomment-541153886, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YHOYLYSXRNST35LHMTQOCZVTANCNFSM4I73R4UA .

craig-dae commented 5 years ago

Let me try bumping Angular itself then

craig-dae commented 5 years ago

bumped everything up. Same result. 7.3.4 (and presumably still 7.3.3) show that error. 7.3.2 works.

KillerCodeMonkey commented 5 years ago

Then i do not get IT. Could you check the deps in my example Repo with yours?

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 19:55:

bumped everything up. Same result. 7.3.4 (and presumably still 7.3.3) show that error. 7.3.2 works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YBTUXU7WSHVJ6DK7ATQOC4Y7A5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAX24I#issuecomment-541162865, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YD5X5VDEWG7QFFK5NDQOC4Y7ANCNFSM4I73R4UA .

craig-dae commented 5 years ago

here? https://github.com/KillerCodeMonkey/ngx-quill/blob/master/package.json

craig-dae commented 5 years ago

no luck: 

"dependencies": {
    "@agm/core": "1.0.0-beta.5",
    "@angular/animations": "8.1.1",
    "@angular/cdk": "8.2.3",
    "@angular/common": "^8.2.9",
    "@angular/compiler": "^8.2.9",
    "@angular/core": "^8.2.9",
    "@angular/forms": "^8.2.9",
    "@angular/platform-browser": "^8.2.9",
    "@angular/platform-browser-dynamic": "^8.2.9",
    "@angular/flex-layout": "^8.0.0-beta.26",
    "@angular/material": "8.2.3",
    "@angular/router": "8.1.1",
    "@fortawesome/fontawesome-free": "5.5.0",
    "@ngrx/effects": "^8.2.0",
    "@ngrx/entity": "^8.2.0",
    "@ngrx/router-store": "^8.2.0",
    "@ngrx/schematics": "^8.2.0",
    "@ngrx/store": "^8.2.0",
    "@ngrx/store-devtools": "^8.2.0",
    "@ngx-progressbar/core": "^5.3.2",
    "@ngx-progressbar/http": "^5.3.2",
    "@ngx-translate/core": "11.0.1",
    "@ngx-translate/http-loader": "4.0.0",
    "@swimlane/ngx-datatable": "15.0.0",
    "@thisissoon/angular-inviewport": "^4.2.0",
    "angular2-text-mask": "9.0.0",
    "bootstrap": "4.3.1",
    "chart.js": "2.7.3",
    "classlist.js": "1.1.20150312",
    "core-js": "^3.2.1",
    "enhanced-resolve": "3.3.0",
    "eslint": "^5.16.0",
    "hammerjs": "2.0.8",
    "intl": "1.2.5",
    "jqcloud2": "2.0.3",
    "jquery": "^3.4.1",
    "jquery-slimscroll": "1.3.8",
    "jquery-sparkline": "2.4.0",
    "jquery.browser": "0.1.0",
    "lodash": "4.17.11",
    "modernizr": "^3.7.1",
    "moment": "2.22.2",
    "ng2-charts": "1.6.0",
    "ng2-file-upload": "1.3.0",
    "ng2-material-dropdown": "0.10.1",
    "ng2-validation": "4.2.0",
    "ngrx-store-freeze": "^0.2.4",
    "ngx-bootstrap": "4.2.0",
    "ngx-chips": "2.0.2",
    "ngx-clipboard": "^12.1.2",
    "ngx-infinite-scroll": "6.0.1",
    "ngx-page-scroll-core": "^6.0.2",
    "ngx-quill": "^7.3.4",
    "ngx-select-ex": "^3.6.11-dev",
    "ngx-toastr": "^10.0.4",
    "popper.js": "1.14.3",
    "quill": "^1.3.7",
    "roboto-fontface": "0.10.0",
    "rxjs": "^6.5.3",
    "rxjs-compat": "6.1.0",
    "simple-line-icons": "2.4.1",
    "spinkit": "1.2.5",
    "ts-helpers": "^1.1.2",
    "tslib": "^1.10.0",
    "uuid": "^3.3.2",
    "web-animations-js": "2.2.1",
    "zone.js": "0.9.1"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.800.0",
    "@angular/compiler-cli": "^8.2.9",
    "@angular/cli": "8.3.9",
    "@angular/language-service": "8.1.1",
    "@types/node": "^12.7.10",
    "@types/quill": "^1.3.10",
    "@typescript-eslint/eslint-plugin": "^2.3.2",
    "@typescript-eslint/parser": "^2.3.2",
    "@types/lodash": "4.14.118",
    "codelyzer": "^5.1.2",
    "cypress": "3.3.1",
    "loaders.css": "0.1.2",
    "protractor": "5.4.0",
    "ts-node": "7.0.0",
    "tslint": "5.11.0",
    "typescript": "3.4.5",
    "webdriver-manager": "10.2.5"
  }
ERROR in ./node_modules/ngx-quill/fesm5/ngx-quill.js
Module build failed (from ./node_modules/@angular-devkit/build-optimizer/src/build-optimizer/webpack-loader.js):
TypeError: Cannot read property 'kind' of undefined
    at isAngularDecoratorMetadataExpression
KillerCodeMonkey commented 5 years ago

Nope with the ngx-quill-example repo

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 20:51:

here? https://github.com/KillerCodeMonkey/ngx-quill/blob/master/package.json

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YD7WXAULWWPKFXN7JDQODDKRA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBA4S7A#issuecomment-541182332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YD3ORHNINVSY2NH7PTQODDKRANCNFSM4I73R4UA .

craig-dae commented 5 years ago

same result again

KillerCodeMonkey commented 5 years ago

Strange because the prod build of this Repo is working

Craig notifications@github.com schrieb am Fr., 11. Okt. 2019, 21:32:

same result again

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YBOZUTW3HKYXKYOMXDQODIGRA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBA73KA#issuecomment-541195688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YDLLFV7HKNR6KKQ24TQODIGRANCNFSM4I73R4UA .

nlaveck commented 5 years ago

I'm getting the same issue after an update and downgrading the version fixed it for me as well

nlaveck commented 5 years ago

@KillerCodeMonkey Does the repo prod build use the angular devkit build optimizer? I think that is what is causing the build to fail

KillerCodeMonkey commented 5 years ago

I have to check this :)

nlaveck notifications@github.com schrieb am Fr., 11. Okt. 2019, 22:11:

@KillerCodeMonkey https://github.com/KillerCodeMonkey Does the repo prod build use the angular devkit build optimizer? I think that is what is causing the build to fail

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YEGJIFWDZCBYYN2NZ3QODMVRA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBCX7Y#issuecomment-541207551, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YH5HZQTP2M2KECAIOLQODMVRANCNFSM4I73R4UA .

KillerCodeMonkey commented 5 years ago

i found a stackoverflow post about it: https://stackoverflow.com/questions/57891605/angular-cli-build-prod-typeerror-cannot-read-property-kind-of-undefined

maybe that helps. But it could be that the typescript upgrade breaks something else.

KillerCodeMonkey commented 5 years ago

@nlaveck @craig-dae any updates?

petemcwilliams commented 5 years ago

Getting the same issue, I'm not inclined to install typescript 3.7 as was suggested in the linked stackoverflow post that would require going to the next release of angular rather than using the released version 8

ERROR in The Angular Compiler requires TypeScript >=3.4.0 and <3.6.0

EDIT - Seen that someone commented on that thread that typescript 3.6.4 should fix the issue, however angular's current version 8.3.9 reports the error above, so I'll wait till angular gets the update, and let you know

KillerCodeMonkey commented 5 years ago

thanks man

nlaveck commented 5 years ago

@KillerCodeMonkey I tried updating typescript and ran into the same problems that @petemcwilliams reported. I'm fine with rolling back ngx-quill so I'm going to do that until an official solution comes out.

thinkdj commented 5 years ago

@KillerCodeMonkey Tried everything mentioned here and also on the SO thread. No luck. --prod build is giving same error as @craig-dae listed

Update: Downgraded to ngx-quill: 6.3.1 and it builds w/o errors! My typescript was 3.4.5 and Angular/CLI was 8.0.3. ngx-quill 7.x.x was failing

jek-bao-choo commented 5 years ago

Same. I am experiencing the error too. I am on "ngx-quill": "^7.1.2",

KillerCodeMonkey commented 5 years ago

Like already mentioned IT seems Not to be a ngx-quill issue. More an angular and typescript one.

Jek Bao CHOO notifications@github.com schrieb am Mi., 16. Okt. 2019, 20:22:

Same. I am experiencing the error too. I am on "ngx-quill": "^7.1.2",

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YF4GBKSTXLCOKHHPGDQO5LU5A5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNOZJA#issuecomment-542829732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YCSGKS3WNWS6FKKPO3QO5LU5ANCNFSM4I73R4UA .

Yexan commented 5 years ago

Yes, this issue is the Angular compiler. If you update all your dependencies you'll get ERROR in The Angular Compiler requires TypeScript >=3.4.0 and <3.6.0 but 3.6.4 was found instead If you downgrade your typescript version it will be ok. (even if it's crappy to downgrade a dep version but waiting for Angular to update the Compiler we got no choice)

Yexan commented 5 years ago

PS: here is my working package.json if it can help :

{
  "name": "rm-editor",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^8.2.11",
    "@angular/cdk": "^8.2.3",
    "@angular/common": "^8.2.11",
    "@angular/compiler": "^8.2.11",
    "@angular/core": "^8.2.11",
    "@angular/forms": "^8.2.11",
    "@angular/platform-browser": "^8.2.11",
    "@angular/platform-browser-dynamic": "^8.2.11",
    "@angular/router": "^8.2.11",
    "exif-js": "^2.3.0",
    "lodash": "^4.17.15",
    "ngx-cookie-service": "^2.2.0",
    "ngx-drag-drop": "^2.0.0",
    "ngx-quill": "^7.1.2",
    "quill": "^1.3.7",
    "rxjs": "^6.5.3",
    "tslib": "^1.9.0",
    "zone.js": "^0.9.1"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^0.803.12",
    "@angular/cli": "^8.3.12",
    "@angular/compiler-cli": "^8.2.11",
    "@angular/language-service": "^8.2.11",
    "@types/jasmine": "^3.4.4",
    "@types/jasminewd2": "^2.0.8",
    "codelyzer": "^5.1.2",
    "jasmine-core": "^3.5.0",
    "jasmine-spec-reporter": "^4.2.1",
    "karma": "^4.4.0",
    "karma-chrome-launcher": "^2.2.0",
    "karma-coverage-istanbul-reporter": "^2.1.0",
    "karma-jasmine": "^2.0.1",
    "karma-jasmine-html-reporter": "^1.4.0",
    "protractor": "^5.4.0",
    "ts-node": "^7.0.0",
    "tslint": "^5.20.0",
    "typescript": "3.5.3"
  }
}
swapnilp0x00 commented 4 years ago

I had faced the same ERROR in The Angular Compiler requires TypeScript >=3.4.0 and <3.6.0 but 3.6.4 was found instead issue earlier and we were using typescript: ^3.2.4 in package.json file so the version was jumping above 3.6. Simply limiting the typescript version like typescript: ~3.2.4 also worked for me.

ddannenb commented 4 years ago

Same issue. Had to downgrade to 6.3.1 to compile in prod. typescript: 3.4.3, @angular/compiler: 8.1.2

coleman17 commented 4 years ago

This was happening for me as well, but upgrading from 7.3.1 -> 7.3.2 fixed it. Angular v8.1.3

KillerCodeMonkey commented 4 years ago

please let me know if there is a fix landed in angular :).

petemcwilliams commented 4 years ago

Looks like no errors with these values "@angular/animations": "^8.2.12", "@angular/cdk": "^8.2.3", "@angular/common": "^8.2.12", "@angular/core": "^8.2.12", "@angular/forms": "^8.2.12", "@angular/platform-browser": "^8.2.12", "@angular/platform-browser-dynamic": "^8.2.12", "@angular/router": "^8.2.12", "@angular-devkit/architect": "^0.803.14", "@angular-devkit/build-angular": "^0.803.14", "@angular-devkit/core": "^8.3.14", "@angular-devkit/schematics": "^8.3.14", "@angular/cli": "^8.3.14", "@angular/compiler": "^8.2.12", "@angular/compiler-cli": "^8.2.12", "@angular/language-service": "^8.2.12",
"typescript": "~3.5.3" "ngx-quill": "7.3.7",

yonathan06 commented 4 years ago

For me updating @angular/common to version 8.2.12 using ng update solved this problem. Notice: I had to install tslib (npm install tslib@^1.10.0 --save-dev), apparently the new angular version relies on it when creating a production build

KillerCodeMonkey commented 4 years ago

thanks mate and everyone contributing to this issue.

I will close this issue here. because it is an angular + typescript problem. Feel free to reopen it or comment your solutions.

vvemuru commented 4 years ago

Hello Everyone,

We ran into the same issue today and it was discovered that a 3rd party library had made a push and that is what was giving the above error.

The reason: we had a ^ next to the package version in package.json and it was pulling in the latest version on every build.

You might want to check and see if there is a ^ sign next to your 3rd party libraries and see if there were any latest releases.

jek-bao-choo commented 4 years ago

Noted. I solved the problem by fixing the version issue. Like what you did, removing ^.

On Fri, 1 Nov 2019, 4:25 AM Vinod, notifications@github.com wrote:

Hello Everyone,

We ran into the same issue today and it was discovered that a 3rd party library had made a push and that is what was giving the above error.

The reason: we had a ^ next to the package version in package.json and it was pulling in the latest version on every build.

You might want to check and see if there is a ^ sign next to your 3rd party libraries and see if there were any latest releases.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=ABRK4QEM7DNDOPEKOLB2J33QRM5NDA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZELJI#issuecomment-548554149, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRK4QBONLG5B4MGBZA5IELQRM5NDANCNFSM4I73R4UA .

balticmirages commented 4 years ago

removing ^ and fixing the release version really helps to solve this problem. thanks everyone

mlh1421 commented 4 years ago

removing ^ and fixing the release version really helps to solve this problem. thanks everyone 这个最有用，去掉^解决了问题，玄学

dchabrier commented 4 years ago

@KillerCodeMonkey Tried everything mentioned here and also on the SO thread. No luck. --prod build is giving same error as @craig-dae listed

Update: Downgraded to ngx-quill: 6.3.1 and it builds w/o errors! My typescript was 3.4.5 and Angular/CLI was 8.0.3. ngx-quill 7.x.x was failing

dchabrier commented 4 years ago

rolling back to version 6.3.1 fixed my issue as well.

KillerCodeMonkey commented 4 years ago

Like i already Said. This is Not a ngx-quill Thing. This is an issue of angular and typescript.

Ngx-quill is working with the latest angular Versions - See my example Repo. There are many GitHub and Stack overflow issues about it.

dchabrier notifications@github.com schrieb am Sa., 9. Nov. 2019, 01:43:

rolling back to version 6.3.1 fixed my issue as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YEYMBSZ7KXIBZTT6YLQSYBURA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTYVYQ#issuecomment-552045282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YAK4OHHEHM3RVWSAPLQSYBURANCNFSM4I73R4UA .

KillerCodeMonkey commented 4 years ago

But If someone could Share an Repo where i can reproduce the issue i will Look into IT again

Bengt Weiße bengtler@googlemail.com schrieb am Sa., 9. Nov. 2019, 08:54:

Like i already Said. This is Not a ngx-quill Thing. This is an issue of angular and typescript.

Ngx-quill is working with the latest angular Versions - See my example Repo. There are many GitHub and Stack overflow issues about it.

dchabrier notifications@github.com schrieb am Sa., 9. Nov. 2019, 01:43:

rolling back to version 6.3.1 fixed my issue as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YEYMBSZ7KXIBZTT6YLQSYBURA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTYVYQ#issuecomment-552045282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YAK4OHHEHM3RVWSAPLQSYBURANCNFSM4I73R4UA .

jek-bao-choo commented 4 years ago

Yes working with latest version of Angular V 8. I upgraded my angular.

On Sat, 9 Nov 2019, 3:55 PM Bengt Weiße, notifications@github.com wrote:

Like i already Said. This is Not a ngx-quill Thing. This is an issue of angular and typescript.

Ngx-quill is working with the latest angular Versions - See my example Repo. There are many GitHub and Stack overflow issues about it.

dchabrier notifications@github.com schrieb am Sa., 9. Nov. 2019, 01:43:

rolling back to version 6.3.1 fixed my issue as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=AARI4YEYMBSZ7KXIBZTT6YLQSYBURA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTYVYQ#issuecomment-552045282 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AARI4YAK4OHHEHM3RVWSAPLQSYBURANCNFSM4I73R4UA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/573?email_source=notifications&email_token=ABRK4QCBQ2JCZOIH6CLCWBLQSZUFXA5CNFSM4I73R4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUAJCY#issuecomment-552076427, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRK4QGNHSXRG2WL6NJJM6TQSZUFXANCNFSM4I73R4UA .

raugaral commented 4 years ago

update the package: "@angular-devkit/build-angular": "^0.803.12"