&mt modifier first parameter should accept any key

KinesisCorporation / Adv360-Pro-GUI

Keymap Editor for the Advantage360 Pro with ZMK

Apache License 2.0

22 stars 53 forks source link

&mt modifier first parameter should accept any key #13

Open fipso opened 1 year ago

fipso commented 1 year ago

Hello, after applying the &mt modifier I can only choose from mod keys like ctrl, shift, etc. as the first parameter. ZMK supports any key there.

Example Keymap: https://github.com/fipso/Adv360-Pro-ZMK/blob/V2.0/config/adv360.keymap#LL46C1-L47C1

edit: fix 2nd parameter typo. i am talking about the first one

KinesisCorporation commented 1 year ago

Thanks for flagging this and we're looking into it.

We inherited all of the "rules" for the GUI but we're working on an update that would allow the user to input any behavior or code anywhere in the GUI (with a warning) so in the future these kinds of bugs don't have to slow people down.

KinesisCorporation commented 1 year ago

GUI now supports writing custom key codes. Please test it out and see if it is viable as a temporary workaround.

fipso commented 1 year ago

Amazing thank you

KinesisCorporation commented 1 year ago

Please let us know if it addresses the issue you were having.

MenJeremy commented 1 year ago

@fipso latest version now supports any key as first/seconds parameters for &mt behavior.

zemackdaddy commented 10 months ago

How does one use &mt in the gui to have the hold select a layer? That is the first use of &mt in the docs but I am not given a choice to select a layer.

KinesisCorporation commented 10 months ago

The &MT example we're seeing pertains to a modifier, not a layer shift. If a layer is supported you should be able to copy that syntax and edit the config file. The GUI doesn't have explicit support for a layer with &MT but you could try using the newer "Apply Custom Code" feature to have the GUI manually write the layer token ("1" maybe) and let us know if that works.

zemackdaddy commented 10 months ago

True story: I had my head in the wrong place, gave you a link to something I barely read, and I was looking for &lt to begin with.

Sorry!