Closed arranf closed 6 years ago
@arranf Everything looks good except the performance hit with Save being called every time there is a new family. I'm guessing the bugs with families not being tracked in memory might be caused by the AsNoTracking calls earlier in the lookup process. I'm gonna try and pull this in with a few modifications.
@dcs619 Alright cool. I'll watch this with interest!
Closing, this has been fixed in the latest version
If in a CSV you had three family members that belonged to the same family consecutively and the family hadn't been created then they would end up in three separate families. Not 🆒 .
This PR ensures that families that are created are tracked in memory. It also fixes a number of Resharper identified code issues including unuused variables, a lack of null checking, and using more specific variable typing than necessary.