KingdomFirst / RockBlocks

KFS repository for all Rock Blocks.
https://www.kingdomfirstsolutions.com/rock
Apache License 2.0
5 stars 1 forks source link

Shelby Financials Exception with multiple batches selected #115

Closed nateh777 closed 2 years ago

nateh777 commented 2 years ago

Description

What does the change add or fix?

Fix for "Wait operation timed out" due to having too many integers in a NOT IN() SQL query when attempting to export multiple batches. Don't convert to list of Integers first so it can handle it with a SQL query instead.

Previous Query (Not in could get 39,000+ integers in it): SELECT ... WHERE ... AND ( NOT ([Extent1].[Id] IN (...)))

New Query: SELECT ... WHERE ... AND ( NOT EXISTS (SELECT ...


Release Notes

What does the change add or fix in a succinct statement that will be read by clients?

Requested By

Who reported, requested, or paid for the change?

College


Screenshots

Does this update or add options to the block UI?

No


Change Log

What files does it affect?

ShelbyFinancials/BatchesToJournal.ascx.cs


Migrations/External Impacts

Is it a breaking change for other versions/clients?

No