search

Kinrany / vue-p5

Vue component for p5.js
125 stars 16 forks source link

p5Events not defined #15

Closed shellby1 closed 5 years ago

shellby1 commented 5 years ago

File: p5.vue Line: 44 "p5Events() {" should be "p5Events: function() {"; Line: 55 "for (const p5EventName of p5Events) {" should be "for (const p5EventName of this.p5Events) {"

Kinrany commented 5 years ago

Thank you for the report, I'll fix this ASAP.

Kinrany commented 5 years ago

I pulled 0.8.x-rc1 and published 0.8.x-rc2 with a fix.

vue-p5@latest now points to 0.7.1 as it should. You might want to use vue-p5@next if you need p5@0.9.0 or windowResized.

Kinrany commented 5 years ago

And thanks again for letting me know about this. I really need to add minimal tests and CI checks here.

If you feel like making a pull request against release-8.0, I'd be happy to replace commit fe749b2b since you're the one who actually found the problem 😃