Crash when loading large binlog

[mthalman]

This large binlog (~ 62 MB) will cause the viewer to crash when opening: binlog link.

This is a regression that was introduced in version 2.2.342. It loads correctly in version 2.2.336. It still fails to load with the latest version (2.2.379) as well.

[KirillOsenkov]

Thanks for reporting!

The build had some circular project references. I made it so it reports them instead of stack overflowing:

[KirillOsenkov]

What's weird that neither WinDbg nor VS would show the call stack of the stack overflow, and I don't know why. Your hint was helpful, so I diffed all the changes between 336 and 342 and spotted a recursive algorithm I added.

[KirillOsenkov]

Published

• https://github.com/KirillOsenkov/MSBuildStructuredLog/releases/tag/v2.2.383
• https://www.nuget.org/packages/MSBuild.StructuredLogger/2.2.383
• https://www.nuget.org/packages/binlogtool/1.0.22