KislakCenter / VisColl

Modeling and visualizing physical manuscript collation
https://viscoll.org/
MIT License
50 stars 9 forks source link

Bug with left/right position usage #9

Closed demery closed 2 years ago

demery commented 2 years ago

In the referenced code leftFolioFilename and rightFolioFilename both use $bi1, but above separate left and right variables are created $bi1 and $bi2:

                            <xsl:variable name="bi1" select="inside/left/leaf/vc:q/@position"/>
                            <xsl:variable name="bi2" select="inside/right/leaf/vc:q/@position"/>

Is the duplicated use of bi1 a bug?

https://github.com/KislakCenter/VisColl/blob/a993930f9c4d8afbfbc161f5d205620e9c2d815d/data/xslt/viscoll_mod2_processed-XML_to_HTML.xsl#L377-L390

acampagnolo commented 2 years ago

Resolved the bug and pushed