[Bug] Canine Pepper does not transform cock

[brrritssocold]

I have checked the following before submitting this issue:

• [x] The bug is still present in the latest release
• [x] Searched the existing issues so I do not open a duplicate issue
• [x] Filled out the template, so developers are less likely to ask for more info

Overview

Consuming any Canine Pepper (with the exception of the double pepper and knotty pepper) does not transform the players cock.

Game version

CoC 1.0.2 - Mod v1.4.13b

Expected behaviour

Using Canine Peppers will eventually turn the cock into dog's.

Actual behaviour

All other transformations happen, but the cock does not transform.

How often can this be reproduced?

Always

Steps to reproduce the issue

1. Enter debug mode
2. Spawn different Canine Peppers
3. Spam any type of Pepper (except the double pepper or knotty pepper)

[Stadler76]

I think I got it (In line 336 of CaninePepper.as):

                if (player.dogCocks() < player.cocks.length && ((changes < changeLimit && rand(1.6)) || type == 1) === 0) {

I'm working on a fix while I'm implementing type constants.

[Stadler76]

Note: Haven't looked at the blame, but it seems, that this was a regression. Hence the label.

[Stadler76]

Ok, after digging further into the blame's and the history: It's a very old bug. The === 0 at the very end of line 336 (See above) was misplaced a long time ago. Probably from the beginning.

[brrritssocold]

Odd part is that I remember the peppers working until not to long ago, maybe something else cause the bug to surface.