Nadro/adhoc/enter sketch mode bug fix

[nadr0]

closes https://github.com/KittyCAD/modeling-app/issues/4524

Bug

https://github.com/user-attachments/assets/c2a5f9d2-d27d-4c2e-9721-ce946c6f0cdc

When you click in a specific timing window you can brick the ray casting into the threejs scene. Josh reported this bug.

Root cause

The three.js intersection plane and draft point groups were not being properly created. This means that the raycasting code on the plane to pick the points would return an empty array and say nothing was intersected.

Issues

• createIntersectionPlane is being added and removed in several locations when it does not need to be
• draftPointGroups were being appended to over time and not properly removed
• We entered the Line tool twice when going into the mode due to a proxy state

Fixes

• I only create the intersection plane once within the constructor because it can live for the entire application runtime. State does not need to be managed for this three.js scene child
• draftPointGroups are tracked within the class to be added to an array then cleared when _teardownsketch is called. They should not be infinitely appended to the array
• Line tool is only ever entered once when entering sketch mode.

Future issues

I can still recreate the issue but what is happening is the system appears to buffer a bunch of clicks then render them all at once then goes back to normal.

I can attempt to fix this in another PR because they are two separate issues. The original bug prevented you from clicking points. This new bug is a delay in the rendering of the mouse clicks.

[qa-wolf[bot]]

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Nov 22, 2024 3:50pm