search

KittyCAD / modeling-app

The KittyCAD modeling app.
https://kittycad.io/modeling-app/download
MIT License
429 stars 37 forks source link

fix: upon entering sketch mode, axis do not rotate. #4572

Open nadr0 opened 3 days ago

nadr0 commented 3 days ago

Issue

The axis for sketch mode can have a rotation applied when entering the sketch mode which is wrong.

How to recreate the bug

Do not look perpendicular to your sketch plane then enter the sketch mode on that plane. Some rotation will be applied

Fix

Set the orientation from the cam settings directly to the camera instead of recomputing a new up vector. Turns out we can use the up vector from the camera settings that is returned instead of hard coding it to <0,1,0>.

Video description

https://github.com/user-attachments/assets/6bc8725d-42bb-45e4-bc40-07991b5575c7

qa-wolf[bot] commented 3 days ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 26, 2024 7:09pm