Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

perf: properly disable CubeAxes on GeometryRepresentation #43

Closed FezVrasta closed 3 years ago

FezVrasta commented 3 years ago

We noticed a lot of calls to the vtkCubeAxesActor were slowing down our app when we tried to update (add and remove) many GeometryRepresentations at the same time.

This change should make sure CubeAxes is never initialized or called if showCubeAxes is not true.

jourdain commented 3 years ago

:tada: This PR is included in version 1.8.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: