Kitware / react-vtk-js

Declarative library exposing vtk.js visualization pipeline as React components
https://kitware.github.io/react-vtk-js/
77 stars 24 forks source link

fix(DataArray): add range info to DataArray #74

Closed jadh4v closed 2 years ago

jadh4v commented 2 years ago

Pass range information to DataArray externally if available, to avoid multiple calls to computeRange, since this can be a performance penalty if the image data is very large. Example shown below:

<DataArray
    registration="setScalars"
    values={dataArray}
    range={{ min: range[0], max: range[1] }}
/>
floryst commented 2 years ago

LGTM!

jadh4v commented 2 years ago

@floryst @jourdain can we merge this?

jourdain commented 2 years ago

:tada: This PR is included in version 1.12.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: