WSLink examples are broken.

Kitware / wslink

Python/JavaScript library for communicating over WebSocket

https://kitware.github.io/wslink/

BSD 3-Clause "New" or "Revised" License

83 stars 26 forks source link

WSLink examples are broken. #156

Closed ajain-work closed 5 months ago

ajain-work commented 5 months ago

Describe the bug

After introducing msgpack+chunking in PR C++ example is not working.

To Reproduce

Please try to run example

Code

Please check code here

Json data is sent instead of binary.

Expected behavior

example should work.

Platform:

Linux

Device:

[x] Desktop
[ ] Mobile

OS:

[ ] Windows
[ ] MacOS
[x] Linux
[ ] Android
[ ] iOS

Browsers Affected:

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] IE (Version)

wslink version: vMAJOR.MINOR.PATCH

jourdain commented 5 months ago

Good catch, let me remove it from the repo since it is only compatible with wslink<2

ajain-work commented 5 months ago

Hi @jourdain, I think it will be good if you can fix the examples instead of removing them. Example are helpful to user. Regards

jourdain commented 5 months ago

By removing, I'm not talking about the example but the full C++ implementation (Already done). Especially since it does not make sense to keep maintaining a feature that is not used. But if a customer does request the support, it will be easy to revive and update the code. Right now, we don't have funding to maintain that C++ side, so it is easier to remove it to prevent miss usage.

Keep in mind, that it still possible to use wslink<2 in C++ as a client.

Hope that make sense