Refactor dependencies - Githubissues

Kitware / wslink

Python/JavaScript library for communicating over WebSocket

https://kitware.github.io/wslink/

BSD 3-Clause "New" or "Revised" License

83 stars 27 forks source link

Refactor dependencies #69

Closed scottwittenburg closed 3 years ago

scottwittenburg commented 3 years ago

In addition to removing twisted and autobahn dependencies from wslink, this PR has a number of other benefits:

Create a server architecture which is agnostic to back end implementation, but is initially based on aiohttp
Improve server api (pass a config object to server.create_server())
Simple migration path for existing applications (simply replace twisted.internet.reactor.callLater with wslink.schedule_callback`)
Opens the door for future applications to use python async features

Some remaining todo items:

[x] fix check ready method
[x] remove remaining references to twisted, reactor, autobahn
[ ] run the tests in python/src/tests/testWSProtocol.py
[x] go through features list in #70
[x] rewrite history

jourdain commented 3 years ago

It is not easy to look at the diff but seems reasonable... Going to look at the code locally to see if I see any missing part.