search

Kitware / wslink

Python/JavaScript library for communicating over WebSocket
https://kitware.github.io/wslink/
BSD 3-Clause "New" or "Revised" License
83 stars 27 forks source link

fix(python): downgrade the startup log message #82

Closed yasushi-saito closed 2 years ago

yasushi-saito commented 2 years ago

Downgrade the level of wslink startup message from critical to info.

A clear and concise description of what the problem was and how this pull request solves it.

fix #ISSUE_NUMBER

jourdain commented 2 years ago

This is a required message used by many launcher configuration. Any reason to silence it by default?

yasushi-saito commented 2 years ago

We have a log monitoring and alerting system that triggers on error or critical messages. So the use of logging.critical for non-critical messages confuses it. We can (and do) specifically exclude certain message patterns, but I think it's better to downgrade the level.

Does the message have to be critical?

On Fri, Dec 24, 2021 at 10:42 AM Sebastien Jourdain < @.***> wrote:

This is a required message used by many launcher configuration. Any reason to silence it by default?

— Reply to this email directly, view it on GitHub https://github.com/Kitware/wslink/pull/82#issuecomment-1000914900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFLM6CLQTJSBUPKQ27AFTUSS5J5ANCNFSM5KV75QRQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Yasushi Saito

jourdain commented 2 years ago

Replacing with a simple print should work. The logger.critical was intended to always show regardless of logger config.

jourdain commented 2 years ago

:tada: This PR is included in version 1.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: