Open Klaim opened 2 years ago
Firstly, it makes sense 0.14.0 doesn't work since these packages use features only available in 0.15.0-.
Regarding the uncommitted error, if I compare the two logs, one without dist.uncommitted=true
/error and the other with/no-error, other things seem to have changed. For example, the first refers to imgui-core
while the second to imgui
. Could you re-run both tests one more time hopefully with the same initial conditions?
Yeah the imgui package PR commits have changed in between and the download reflect that.
I re-tried but I couldnt reproduce the error. I suspect that something was changed recently in the imgui package PR that removed the issue (see log below).
I'll try to find the exact commit where the error was visible (later today).
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (main)
$ rm -rf .bdep/ ../build-msvc/
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (main)
$ b --version
build2 0.15.0-a.0.3ec24f8b32f4
libbutl 0.15.0-a.0.c1e9c118b890
host x86_64-microsoft-win32-msvc14.2
Copyright (c) 2014-2022 the build2 authors.
This is free software released under the MIT license.
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (main)
$ bdep init -C ../build-msvc cc
initializing in project E:\projects\build2-packaging\dearimgui\usertest\myapp\
created configuration E:\projects\build2-packaging\dearimgui\usertest\build-msvc\ 1 target default,forwarded,auto-synchronized
fetching git:github.com/Rookfighter/imgui#feature/split-backends (prerequisite of dir:e:\projects\build2-packaging\dearimgui\usertest\myapp)
querying https://github.com/Rookfighter/imgui.git
fetching from https://github.com/Rookfighter/imgui.git
remote: Enumerating objects: 173, done.
remote: Counting objects: 100% (173/173), done.
remote: Compressing objects: 100% (106/106), done.
remote: Total 173 (delta 44), reused 123 (delta 17), pack-reused 0
fetching git:github.com/build2-packaging/opengl-meta#master (prerequisite of git:github.com/Rookfighter/imgui#feature/split-backends)
querying https://github.com/build2-packaging/opengl-meta.git
fetching from https://github.com/build2-packaging/opengl-meta.git
remote: Enumerating objects: 31, done.
remote: Counting objects: 100% (31/31), done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 31 (delta 1), reused 22 (delta 1), pack-reused 0
fetching pkg:cppget.org/stable (prerequisite of git:github.com/build2-packaging/opengl-meta#master)
synchronizing:
new glfw/3.3.4+1 (required by imgui-platform-glfw)
new imgui/1.86.0-a.0.20220602163431.e51d68a64737 (required by imgui-platform-glfw, imgui-render-opengl3)
new imgui-platform-glfw/1.86.0-a.0.20220602163431.e51d68a64737 (required by myapp)
new opengl-meta/1.0.0-a.0.20220601235057.b9271584abf6 (required by imgui-render-opengl3)
new imgui-render-opengl3/1.86.0-a.0.20220602163431.e51d68a64737 (required by myapp)
new myapp/0.1.0-a.0.20220602145537.c4b480561119
glfw-3.3.4+1.tar.gz:
######################################################################################################################################################################################################################################################### 100.0%
checking out imgui/1.86.0-a.0.20220602163431.e51d68a64737
fetching submodule 'upstream' from https://github.com/ocornut/imgui.git
remote: Enumerating objects: 254, done.
remote: Counting objects: 100% (254/254), done.
remote: Compressing objects: 100% (208/208), done.
remote: Total 254 (delta 76), reused 127 (delta 35), pack-reused 0
submodule path 'upstream': checked out '55d35d8387c15bf0cfd71861df67af8cfbda7456'
distributing imgui/1.86.0-a.0.20220602163431.e51d68a64737
distributing imgui-platform-glfw/1.86.0-a.0.20220602163431.e51d68a64737
distributing opengl-meta/1.0.0-a.0.20220601235057.b9271584abf6
distributing imgui-render-opengl3/1.86.0-a.0.20220602163431.e51d68a64737
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (main)
$
I forced using the initial commit of the imgui PR where I saw the issue in the uncommitted
branch of this repo: https://github.com/Klaim/build2-test-usage-imgui/blob/uncommitted/repositories.manifest#L11 (you can clone the imgui PR to look at it's state)
Now reproducing the error as before:
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (uncommitted)
$ b --version
build2 0.15.0-a.0.3ec24f8b32f4
libbutl 0.15.0-a.0.c1e9c118b890
host x86_64-microsoft-win32-msvc14.2
Copyright (c) 2014-2022 the build2 authors.
This is free software released under the MIT license.
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (uncommitted)
$ rm -rf .bdep/ ../build-msvc/
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (uncommitted)
$ bdep init -C ../build-msvc cc
initializing in project E:\projects\build2-packaging\dearimgui\usertest\myapp\
created configuration E:\projects\build2-packaging\dearimgui\usertest\build-msvc\ 1 target default,forwarded,auto-synchronized
fetching git:github.com/Rookfighter/imgui#ce74cec38637822e03c5ac7a5f1bb86b48192f19 (prerequisite of dir:e:\projects\build2-packaging\dearimgui\usertest\myapp)
fetching from https://github.com/Rookfighter/imgui.git
remote: Enumerating objects: 152, done.
remote: Counting objects: 100% (152/152), done.
remote: Compressing objects: 100% (92/92), done.
remote: Total 152 (delta 42), reused 121 (delta 23), pack-reused 0
fetching git:github.com/build2-packaging/opengl-meta#master (prerequisite of git:github.com/Rookfighter/imgui#ce74cec38637822e03c5ac7a5f1bb86b48192f19)
querying https://github.com/build2-packaging/opengl-meta.git
fetching from https://github.com/build2-packaging/opengl-meta.git
remote: Enumerating objects: 31, done.
remote: Counting objects: 100% (31/31), done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 31 (delta 1), reused 22 (delta 1), pack-reused 0
fetching pkg:cppget.org/stable (prerequisite of git:github.com/build2-packaging/opengl-meta#master)
synchronizing:
new glfw/3.3.4+1 (required by imgui-platform-glfw)
new imgui-core/1.86.0-a.0.20220601215117 (required by imgui-platform-glfw, imgui-render-opengl3)
new imgui-platform-glfw/1.86.0-a.0.20220601215117 (required by myapp)
new opengl-meta/1.0.0-a.0.20220601235057.b9271584abf6 (required by imgui-render-opengl3)
new imgui-render-opengl3/1.86.0-a.0.20220601215117 (required by myapp)
new myapp/0.1.0-a.0.20220602145538
glfw-3.3.4+1.tar.gz:
######################################################################################################################################################################################################################################################### 100.0%
checking out imgui-core/1.86.0-a.0.20220601215117
fetching submodule 'upstream' from https://github.com/ocornut/imgui.git
remote: Enumerating objects: 254, done.
remote: Counting objects: 100% (254/254), done.
remote: Compressing objects: 100% (208/208), done.
remote: Total 254 (delta 76), reused 127 (delta 35), pack-reused 0
submodule path 'upstream': checked out '55d35d8387c15bf0cfd71861df67af8cfbda7456'
distributing imgui-core/1.86.0-a.0.20220601215117
error: distribution of uncommitted project ..\build-msvc\.bpkg\tmp\63c3ca6500b9\imgui-core\
info: specify config.dist.uncommitted=true to force
84% of targets distributed
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (uncommitted)
$ rm -rf .bdep/ ../build-msvc/
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (uncommitted)
$ bdep init -C ../build-msvc cc --build-option config.dist.uncommitted=true
initializing in project E:\projects\build2-packaging\dearimgui\usertest\myapp\
created configuration E:\projects\build2-packaging\dearimgui\usertest\build-msvc\ 1 target default,forwarded,auto-synchronized
fetching git:github.com/Rookfighter/imgui#ce74cec38637822e03c5ac7a5f1bb86b48192f19 (prerequisite of dir:e:\projects\build2-packaging\dearimgui\usertest\myapp)
fetching from https://github.com/Rookfighter/imgui.git
remote: Enumerating objects: 152, done.
remote: Counting objects: 100% (152/152), done.
remote: Compressing objects: 100% (92/92), done.
remote: Total 152 (delta 42), reused 121 (delta 23), pack-reused 0
fetching git:github.com/build2-packaging/opengl-meta#master (prerequisite of git:github.com/Rookfighter/imgui#ce74cec38637822e03c5ac7a5f1bb86b48192f19)
querying https://github.com/build2-packaging/opengl-meta.git
fetching from https://github.com/build2-packaging/opengl-meta.git
remote: Enumerating objects: 31, done.
remote: Counting objects: 100% (31/31), done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 31 (delta 1), reused 22 (delta 1), pack-reused 0
fetching pkg:cppget.org/stable (prerequisite of git:github.com/build2-packaging/opengl-meta#master)
synchronizing:
new glfw/3.3.4+1 (required by imgui-platform-glfw)
new imgui-core/1.86.0-a.0.20220601215117 (required by imgui-platform-glfw, imgui-render-opengl3)
new imgui-platform-glfw/1.86.0-a.0.20220601215117 (required by myapp)
new opengl-meta/1.0.0-a.0.20220601235057.b9271584abf6 (required by imgui-render-opengl3)
new imgui-render-opengl3/1.86.0-a.0.20220601215117 (required by myapp)
new myapp/0.1.0-a.0.20220602145538
glfw-3.3.4+1.tar.gz:
######################################################################################################################################################################################################################################################### 100.0%
checking out imgui-core/1.86.0-a.0.20220601215117
fetching submodule 'upstream' from https://github.com/ocornut/imgui.git
remote: Enumerating objects: 254, done.
remote: Counting objects: 100% (254/254), done.
remote: Compressing objects: 100% (208/208), done.
remote: Total 254 (delta 76), reused 125 (delta 35), pack-reused 0
submodule path 'upstream': checked out '55d35d8387c15bf0cfd71861df67af8cfbda7456'
distributing imgui-core/1.86.0-a.0.20220601215117
distributing imgui-platform-glfw/1.86.0-a.0.20220601215117
distributing opengl-meta/1.0.0-a.0.20220601235057.b9271584abf6
distributing imgui-render-opengl3/1.86.0-a.0.20220601215117
Klaim@KLAIMSTATION2 MINGW64 /e/projects/build2-packaging/dearimgui/usertest/myapp (uncommitted)
$