KlausMikhaelson / VirtualRoom

Watch youtube videos with your friends on Sync
MIT License
22 stars 3 forks source link

Destructure rooms and users properly #11

Closed MahirMahdi closed 1 year ago

MahirMahdi commented 1 year ago

Rooms and users are defined as objects but you're destructuring those as arrays.

Screenshot 2023-01-25 125401

KlausMikhaelson commented 1 year ago

Thanks for pointing it out @MahirMahdi , would you like to work on it ? or should I assign it to myself ?

MahirMahdi commented 1 year ago

I would like to work on it. 😀

MahirMahdi commented 1 year ago

@KlausMikhaelson I found more issues. Your users array isn't updating properly with the current code and it's even showing error while disconnecting.

I've destructed already. So after making a PR for this issue, let make separate issues for updating users array and implementing disconnecting function so that you've a track of the PRs.

What do you think? Let me know. 😀

KlausMikhaelson commented 1 year ago

awesome, thanks for noticing it, I should have come back to this repo and checked it lol, sounds great ! btw do consider giving the repos here a star if you like them !

MahirMahdi commented 1 year ago

Done