Klepac-Ceraj-Lab / Resonance

MIT License
1 stars 0 forks source link

:exclamation: Do this last :exclamation: #130

Closed kescobo closed 1 year ago

kescobo commented 1 year ago

Just before submission, the following steps need to be taken / confirmed:

kescobo commented 1 year ago

Initial submission: To prepare your manuscript in LaTeX, please follow the LaTeX source guidelines below. Generate PDF files for the main text and Supplementary Materials, and upload them in the “Manuscript” and “Supplementary Materials” sections of the “Article” and “Related Documents” tabs. The figures should be included in the PDF files; do not upload them separately at this stage (see the section on Figures in the LaTeX source guidelines below).

kescobo commented 1 year ago

Other ToDos

vanjakle commented 1 year ago

Manuscript - ToDos

** stopping at Ln 327 Stool Sample Collection and Sequencing. will resume when I get to work

vanjakle commented 1 year ago

continuing with the previous...

vanjakle commented 1 year ago

ToDos - Supplementary Material

Hugemiler commented 1 year ago

"Inside the MLJ.jl Machine Learning Framework. Independent RFs ..."

This tackles both the "rogue framework" thing and the one-sentence paragraph.

vanjakle commented 1 year ago
Hugemiler commented 1 year ago
Hugemiler commented 1 year ago
Hugemiler commented 1 year ago

940a08a

kescobo commented 1 year ago

Lns 137 and 166. "predict" in the title. I understand that the model predicts the outcome based on the inputs. however, to a non-ML person, the word predict means something else and that is predicting the future outcome. Would "correlate" be more appropriate here?

I don't think "correlate" captures the right meaning. "Predict" is not only an ML thing, but I kinda agree. @Hugemiler Can you think of a different word that might work? Also, removing the "functional profiles" from that line, since we don't use them.

Vanja: Lns 137 and 166 - checked the wording with Libusha. She says to use "correlate" instead.

kescobo commented 1 year ago

Section after Ln 166 - unclear if all samples with MRIs were used to predict brain structure differences or if you grouped by age. Add a sentence somewhere that all participants, regardless of age, were included in the model. Also, unclear how many samples/participants were included. or if they were the same as the ones that were used to predict cog scores.

@Hugemiler This was all subjects, right?

kescobo commented 1 year ago

@vanjakle re:

Ln 392 - use a different word from "paper". maybe "study"? and "manuscript"?

I copied this from here

image

Please change to All data needed to evaluate the conclusions of this study are present in the manuscript and/or

Hugemiler commented 1 year ago

Section after Ln 166 - unclear if all samples with MRIs were used to predict brain structure differences or if you grouped by age. Add a sentence somewhere that all participants, regardless of age, were included in the model. Also, unclear how many samples/participants were included. or if they were the same as the ones that were used to predict cog scores.

@Hugemiler This was all subjects, right?

This was subjects 18 to 120 months, 1 row per subject, first stool sample inside this age bracket with a matching MRI scan. Total 121 datapoints.

Hugemiler commented 1 year ago

Lns 137 and 166. "predict" in the title. I understand that the model predicts the outcome based on the inputs. however, to a non-ML person, the word predict means something else and that is predicting the future outcome. Would "correlate" be more appropriate here?

I don't think "correlate" captures the right meaning. "Predict" is not only an ML thing, but I kinda agree. @Hugemiler Can you think of a different word that might work? Also, removing the "functional profiles" from that line, since we don't use them.

Vanja: Lns 137 and 166 - checked the wording with Libusha. She says to use "correlate" instead.

I'm extremely partial to "predict" instead of "correlate". I cannot think of a better word, and I do not think one exists. I understand that more and more papers are getting this audience used to this terminology (just google "metagenomics predict IBD" for example and see the high amount of recent papers where classifiers of same-time IBD/control were called "predictors").

I understand that historical data that predicts future data is often called "forecast" or "future prediction", where not implicit on a domain-specific context. If it's extremely important to emphasize that this is not a forecast, how do you feel about addin the word "concurrent" after "predict" ?

Hugemiler commented 1 year ago

@kescobo re removing "functional profiles", are ECs not a type of funcional profile? If we have test-set statistics for them on Table 2, should we not leave them?

kescobo commented 1 year ago

Hmm - I didn't catch that. I think it's weird that we don't say anything about it, nor do anything with those models.

kescobo commented 1 year ago

reverted acbfca8

vanjakle commented 1 year ago
vanjakle commented 1 year ago

Upload a combined pdf that includes the complete main manuscript, figures, and supplementary materials. The combined pdf is used for the evaluation process and it is provided to reviewers.