[modal] Confirm retirement modal UI tweak - Githubissues

KlimaDAO / klimadao

Monorepo for the official KlimaDAO site, dApp, components and design system.

https://klimadao.finance

MIT License

91 stars 71 forks source link

[modal] Confirm retirement modal UI tweak #1963

Open jabby09 opened 8 months ago

jabby09 commented 8 months ago

To replicate:

Login and go to your portfolio page
Select a project/asset to retire and click RETIRE button
On the retire form (for example) select amount and click RETIRE CARBON button
In the Confirm Retirement modal, on both the APPROVE and SUBMIT tabs, note that the Submit amount has a USDC logo

The issue:

Retiring an asset you already own does not require USDC or any form of payment
What the user is confirming in this modal is actually the quantity (tonnes of carbon to retire)
I believe this is happening because we are reusing the component when retiring from a pool listings (for example) which does require USDC payment. In this case the Confirm amount is the Total cost showing the USDC symbol makes sense

Design question

[ ] @theprofessora Should Confirm amount in these modals be the amount of carbon or the in the case of retire from a pool was they intent that the Confirm amount was the total cost?
[ ] @theprofessora depending on answer to above, should we standardize these or do we need to support one modal that shows cost and one modal that shows quantity?

theprofessora commented 8 months ago

Yes, the confirm should be the amount to retire. I think we should have one modal that shows all necessary fields.

So if there's a payment required, we should have 3 fields: contract address, confirm price, confirm quantity.

If there's no payment required, we should have 2 fields: contract address, confirm quantity.

I'll update the designs in figma