search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.32k stars 5.28k forks source link

bme280: Add BMP388 sensor support to BMxx80 #6576

Closed linw1995 closed 5 months ago

linw1995 commented 5 months ago

Extends the BMxx80 category with support for the BMP388 sensor, providing temperature and pressure output similar to the existing BMxx80 class of sensors.

KevinOConnor commented 5 months ago

Thanks. Maybe @Arksine could take a look at this.

-Kevin

Arksine commented 5 months ago

The implementation looks solid to me. I wish that the BME388 did not introduce a new chip ID register, however it appears that the original ID register (0xD0) is not mapped, so it should reliably return 0 when read.

KevinOConnor commented 5 months ago

Thanks.

-Kevin