search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.32k stars 5.28k forks source link

Replace logging.warn usage with logging.warning #6580

Closed jelly closed 4 months ago

jelly commented 5 months ago

logging.warn is an alias to logging.warning since Python 3.3 and will be removed in Python 3.13.

JamesH1978 commented 5 months ago

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.

Thanks James

jelly commented 4 months ago

Sorry, done!

thijstriemstra commented 4 months ago

in #6385 i addressed this issue and disheartening to see the same code was added again at some point, without it being caught. Without any code quality checks (eg. flake8) i suppose this will keep happening; brittle.

jelly commented 4 months ago

in #6385 i addressed this issue and disheartening to see the same code being added again. Without any code quality checks (eg. flake8) i suppose this will keep happening; brittle.

Ruff and pylint have a rule for it.

KevinOConnor commented 4 months ago

Thanks.

-Kevin