search

Knio / pynmea2

Python library for parsing the NMEA 0183 protocol (GPS)
MIT License
635 stars 223 forks source link

PTNL PJK File Update #139

Closed arcsump closed 8 months ago

arcsump commented 2 years ago

Discussed in https://github.com/Knio/pynmea2/discussions/138

Originally posted by **arcsump** April 21, 2022 Hi @Knio , Thanks for the awesome library, I needed to extend a proprietary class, wondering if it can be properly incorporated. That would be great, many thanks again - I am not that well-versed so yeah pardon me. Meanwhile, I modified tnl.py and added this snippet `class TNLPJK (TNL, DatetimeFix):` ` fields = (` ` ('Empty', '_'),` ` ('Sentence Type', 'type'),` ` ('Timestamp', 'timestamp', timestamp),` ` ("Datestamp", "datestamp", datestamp),` ` ('Northing', 'northing'),` ` ('Northing Direction', 'northing_dir'),` ` ('Easting', 'easting'),` ` ('Easting Direction', 'easting_dir'),` ` ('GPS Quality', 'gps_quality'),` ` ('Total number of satelites in use', 'num_sats'),` ` ('DOP', 'dop'),` ` ('Height of Antenna Phase Center, GHT or EHT', 'phase_center_height'),` ` )`
kamiccolo commented 10 months ago

Mhm. Weird, I remember making a PR some time ago: https://github.com/Knio/pynmea2/pull/75

Which seems... to get merged only partially. Will see what can I do about that.

arcsump commented 10 months ago

Hi! Thanks Appreciate it, cheers

Marcus

On Sat, Jan 27, 2024, 01:19 kamiccolo @.***> wrote:

Mhm. Weird, I remember making a PR some time ago: #75 https://github.com/Knio/pynmea2/pull/75

Which seems... to get merged only partially. Will see what can I do about that.

— Reply to this email directly, view it on GitHub https://github.com/Knio/pynmea2/issues/139#issuecomment-1912142010, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKCCGGKQN4J42PAABVNBQTYQO3ODAVCNFSM5UNQRZ6KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJRGIYTIMRQGEYA . You are receiving this because you authored the thread.Message ID: @.***>

kamiccolo commented 8 months ago

I believe this can be closed :) PR got merged: https://github.com/Knio/pynmea2/pull/75

Adding: TNLDG, TNLVGK and TNLPJK

arcsump commented 8 months ago

Awesome! Many thanks for this!