search

Koihik / vscode-lua-format

Reformats your Lua source code
Apache License 2.0
56 stars 13 forks source link

Relative configPath does not work with multiple folders added to workspace #21

Closed veger closed 4 years ago

veger commented 4 years ago

Hello,

I was trying to setup a custom config for a specific repo only, so I thought using relative configPath is the solution. But I found some issues, so here is my feedback:

  1. only the first folder seems to be searched/used to load the config
  2. when the config is not found a silent error is thrown (I used debugger to figure out what is going on)
  3. with multiple repos/projects in a single workspace, it would be nice to use default config if the project does not have the config available (file not found), because now the formatter only works for the specific project I made the config file for.

Especially the 2nd is confusing for users, and I would call a bug, as formatting stops working and no feedback is given why. The other 2 are more improvements I guess.

Hope this helps you improving the otherwise nice extension!