search

Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
852 stars 96 forks source link

ME misreporting failed save as successful #1701

Open mihawk90 opened 10 months ago

mihawk90 commented 10 months ago

Describe the bug I just ran into this by accident. It seems that the directory I'm trying to save into has a permissions issue (which I did not realise before), and so ME doesn't have write-access. When saving the movie, it reports a successful save, but as you can imagine, it didn't actually save anything.

To Reproduce Steps to reproduce the behavior:

  1. Have a directory with missing write permissions
  2. Scrape directory for a movie and save
  3. Check the upper right corner and/or console logs

Expected behavior ME should notify the user about the failed save, if possible with an appropriate error message (as seen in the console log warning).

Screenshots image

MediaElch Version:

Operating System:

Additional context Movie is on a NAS, mounted on an NFS share. Seems I messed up my permissions somewhere.

bugwelle commented 10 months ago

Thanks for reporting! Yes, that's a bug. In fact, the log entry is my first approach to log something. A few versions ago, nothing was printed at all. However, I totally forgot about that. It should definitely be shown to the user!