KomodoPlatform / komodo-wallet-desktop

Komodo Wallet Desktop GUI
https://atomicdex.io
GNU General Public License v2.0
238 stars 207 forks source link

[BUG]: wrong chart in DEX tab after switching base from KMD to USDx #1315

Closed cipig closed 2 years ago

cipig commented 3 years ago

Switching from SMTF/KMD to SMTF/USDC in DEX tab by clicking on "Best Orders" (buy SMTF) entry USDC shows chart of KMD/USD: image The bug can be reproduced with any stablecoin, switching base from KMD to BUSD has the same. If switching base from KMD to USDx from coin selection dropdown, the bug is not there, only through "Best Orders".

smk762 commented 2 years ago

@cipig I've been unable to reproduce this one, can you please try again and add a short video of the steps?

cipig commented 2 years ago

can't record videos, but follow this steps:

  1. go to SMTF/KMD orderbook (no chart) image
  2. click on a sell order, so that best_orders show up image
  3. click on the USDCentry, the orderbook will change to SMTF/USDC
  4. result: it shows the charts of KMD/USD image
smk762 commented 2 years ago

Not sure why, but my CLI bestorders response has items not visible in the app. This is using same mm2 instance as in app with app rpcpass. image bestorders.txt

smk762 commented 2 years ago

@cipig appears to be resolved in https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/2057679427 can you please confirm? Currently I see no chart for SMTF-v2 / KMD, nor SMTF-v2 / USDC when selecting from bestorders. Same for BUSD & USDT etc.

cipig commented 2 years ago

weird, i still have the problem

smk762 commented 2 years ago

replicated here also, previously was doing opposite of click on a SMTF ask (as if you would want to buy SMTF and pay with KMD) i.e. clicking on bid (sell SMTF).

Also replicated with same sequence using BTC instead of SMTF. Might need to add some logs to track this down.

cipig commented 2 years ago

bug is there if you switch from xxx/KMD orderbook to xxx/USD orderbook it then shows KMD/USD chart, instead of xxx/USD so there is a pattern somewhere in code (switching orderbook), it selects the wrong side when asking for charts (base is rel and rel is base)