KonSola5 / HephaestusPlus

An addon for Hephaestus.
MIT License
3 stars 2 forks source link

Nothing seems to drop items when Lithium is enabled. #5

Open CaioFrancisco opened 10 months ago

CaioFrancisco commented 10 months ago

Describe the bug

When I enable this mod, breaking blocks and killing mobs drop no items at all. XP seems to drop normally, dropping items from hand works and players drop items normally on death.

To Reproduce

Enable Lithium (0.11.2) and HephaestusPlus (1.1.1+1.20).

Expected behavior

For items to drop.

Crash log or game log (if applicable)

I skimmed through the logs, only found invalid recipe errors related to this mod, because I don't have Mythical Metals.

Mod List

  [✔] ae2wtlib-15.2.1-fabric
  [✔] appleskin-fabric-mc1.20.1-2.5.1
  [✔] Applied-Botanics-fabric-1.5.0
  [✔] appliedenergistics2-fabric-15.0.20
  [✔] architectury-9.1.12-fabric
  [✔] balm-fabric-1.20.1-7.2.1
  [✔] Botania-1.20.1-443-FABRIC
  [✔] carryon-fabric-1.20.1-2.1.2.7
  [✔] cc-tweaked-1.20.1-fabric-1.109.3
  [✔] cloth-config-11.1.106-fabric
  [✔] dynamic-fps-3.3.2+minecraft-1.20.0
  [✔] dynamiclights-v1.7-mc1.17x-1.20x-mod
  [✘] EnchantingInfuser-v8.0.2-1.20.1-Fabric.jar (disabled)
  [✔] entityculling-fabric-1.6.2-mc1.20.1
  [✔] ferritecore-6.0.1-fabric
  [✔] ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric
  [✔] Hephaestus-1.20.1-3.6.3.240
  [✔] hephaestusplus-1.1.1+1.20
  [✔] indium-1.0.27+mc1.20.1
  [✔] lithium-fabric-mc1.20.1-0.11.2
  [✔] memoryleakfix-fabric-1.17+-1.1.2
  [✔] modmenu-7.2.2
  [✔] MouseTweaks-fabric-mc1.20-2.25
  [✔] nvidium-0.2.5-beta
  [✔] Patchouli-1.20.1-84-FABRIC
  [✔] PureCopperTools-v1.0.1-1.20.1-Fabric
  [✘] PuzzlesLib-v8.1.12-1.20.1-Fabric.jar (disabled)
  [✔] qfapi-7.4.0_qsl-6.1.2_fapi-0.90.0_mc-1.20.1
  [✔] reeses_sodium_options-1.6.5+mc1.20.1-build.95
  [✔] RoughlyEnoughItems-12.0.674
  [✔] sodium-extra-0.5.1+mc1.20.1-build.112
  [✔] sodium-fabric-mc1.20.1-0.5.3
  [✔] sound-physics-remastered-fabric-1.20.1-1.3.1
  [✔] trinkets-3.7.1
  [✔] waystones-fabric-1.20-14.1.3
  [✔] wraith-fabricaeexnihilo-1.0.0-beta.4+mc1.20.1

Versions

KonSola5 commented 10 months ago

Hmm, this problem seemed to occur at random in devenv too. Tried to debug, but not sure why and when this occurs...

And it's not Lithium-related - may be a bug in PortingLib.

KonSola5 commented 10 months ago

https://github.com/Fabricators-of-Create/Porting-Lib/issues/74 It seems to be the race condition between Porting Lib and Botania.

Block drops are controlled by loot tables. According to unilock:

Loot tables work when Botania is loaded before Porting Lib, but not when Porting Lib is loaded before Botania.

KonSola5 commented 9 months ago

Should be fixed when the next version of Porting Lib gets released. (And the issue will be closed when the mod will start to require that version of Porting Lib)