Konafets / TYPO3SniffPool

This repository contains custom sniffs which are compatible with the PHP_CodeSniffer. Understand this package as a sniff pool which contains all needed custom sniffs for the various TYPO3 projects.
21 stars 10 forks source link

Take and adjust the code of the Generic.WhiteSpace.DisallowSpaceIndent for TYPO3SniffPool.WhiteSpace.DisallowSpaceIndent #31

Closed andygrunwald closed 9 years ago

andygrunwald commented 10 years ago

We can't take the sniff from the Generic standard because it handles DocComments different

For them its valid if you indent the doc comments with spaces after a tab like this

[tab][space]/*****
[tab][space][space]*
[tab][space][space]*
[tab][space][space]*

[tab] /*****
[tab]  *
[tab]  *
[tab]  *

instead of

[tab]/*****
[tab] *
[tab] *
[tab] *

But we should consider using this sniff as basis because its pretty short in comparison to our sniff

Original Tickets:

Konafets commented 9 years ago

The way the doc comment is checked in the Generic.WhiteSpace.DisallowSpaceIndent are inconsistent. See the issue at https://github.com/squizlabs/PHP_CodeSniffer/issues/393