Use Konnect SDK in Konnect integration tests - Githubissues

Kong / kubernetes-ingress-controller

:gorilla: Kong for Kubernetes: The official Ingress Controller for Kubernetes.

https://docs.konghq.com/kubernetes-ingress-controller/

Apache License 2.0

2.2k stars 590 forks source link

Use Konnect SDK in Konnect integration tests #3550

Open czeslavo opened 1 year ago

czeslavo commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement

In order to unblock ourselves when developing KIC-Konnect integration, we manually generated runtime-groups and runtime-groups-config Go clients to be used in KIC tests: https://github.com/Kong/kubernetes-ingress-controller/pull/3535

In the meantime, an official Go SDK for Konnect APIs was developed: https://github.com/Kong/sdk-konnect-go. We can now use it instead of our own client.

Proposed Solution

Modify testing helpers to use the Konnect SDK instead of the internal client (1, 2).

Additional information

No response

Acceptance Criteria

[ ] Konnect SDK is used to create test control planes and data planes' client certificates in Konnect.

czeslavo commented 1 month ago

https://github.com/Kong/sdk-konnect-go repository contains Konnect SDK that should allow the operations we need in KIC tests:

creating a test control plane: https://github.com/Kong/kubernetes-ingress-controller/blob/7f0eb0424b69be4afb48b363f03f74a78f1eebc5/test/internal/helpers/konnect/control_plane.go#L26 can be modified to use https://github.com/Kong/sdk-konnect-go/blob/main/models/operations/createcontrolplane.go
creating a DP client certificate: https://github.com/Kong/kubernetes-ingress-controller/blob/447b3aefbaaac9e91a417680d8d4b2a124a87af1/test/internal/helpers/konnect/certificates.go#L18 can be modified to use https://github.com/Kong/sdk-konnect-go/blob/main/models/operations/createdataplanecertificate.go