search

Kong / lua-resty-dns-client

Lua DNS client, load balancer, and utility library
http://kong.github.io/lua-resty-dns-client/topics/README.md.html
Apache License 2.0
152 stars 52 forks source link

feat(client) add option to override ttl #57

Closed Tieske closed 6 years ago

Tieske commented 6 years ago

Implements a new option validTtl that, if given, overrides the ttl of any valid answer received from the name server.

closes #48

Tieske commented 6 years ago

I picked validTtl because it is used as the ttl for valid answers (there are others for errors etc). If we'd call it overrideTtl it wouldn't explain which answers it would override.

Additionally, valid is the name of the similar nginx option

regarding the usecase, I referenced the original issue it resolves, but I could repeat it here?

hishamhm commented 6 years ago

ah, my bad, I missed the referenced issue, sorry. the explanation for the name is reasonable as well.

On Thu, Aug 23, 2018, 17:11 Thijs Schreijer notifications@github.com wrote:

I picked validTtl because it is used as the ttl for valid answers (there are others for errors etc). If we'd call it overrideTtl it wouldn't explain which answers it would override.

Additionally, valid is the name of the similar nginx option

regarding the usecase, I referenced the original issue it resolves, but I could repeat it here?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/Kong/lua-resty-dns-client/pull/57#issuecomment-415555584, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO_dfJx-tpXbzS9ZbgFXm9V17XiMkwkks5uTwxtgaJpZM4WJ4NI .