Konnect-Agri / protocol-server-beckn

A gateway router for the Beckn based Konnect APIs
0 stars 3 forks source link

[Protocol Server][Bug] Init response received twice. #3

Closed karntrehan closed 1 year ago

karntrehan commented 1 year ago

Init response coming in 2 times. Need to be fixed. BPP is responding twice.

karntrehan commented 1 year ago

@amit-s19 and @charanpreet-samagra to work on this.

aashutosh-samagra commented 1 year ago

To be picked next week - bandwidth issue

karntrehan commented 1 year ago

To be picked on monday. @amit-s19 to pick this up.

karntrehan commented 1 year ago

Retry mechanism could be misfiring. @amit-s19 to debug further.

amit-s19 commented 1 year ago

Issue has been fixed in the latest PR raised in Agridex-Beckn : https://github.com/Konnect-Agri/AgriDex-Beckn/pull/40

RCA

The application's nature is supposed to be async completely and based on messaging queue architecture however it was breaking during the flow in which Protocol-Server-Network was calling BPP and was waiting for it to complete synchronously leading to HttpTimeout exceptions and thus calling the init service multiple time.

Solution

Init has now been made async just like search service :) with the use of ACK handshake.